From 0adddea81b938eeb068dc9be14cd0cef8a16bec2 Mon Sep 17 00:00:00 2001
From: Kovid Goyal <kovid@kovidgoyal.net>
Date: Thu, 7 Mar 2019 10:36:39 +0530
Subject: [PATCH] Book details panel: Allow editing the identifiers for the
 book by right clicking on the existing Ids. Fixes #1815005 [[Enhancement]
 Allow adding Identifiers on Books Detail
 Panel](https://bugs.launchpad.net/calibre/+bug/1815005)

---
 src/calibre/gui2/book_details.py | 13 ++++++++++---
 src/calibre/gui2/init.py         | 12 ++++++++++++
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/src/calibre/gui2/book_details.py b/src/calibre/gui2/book_details.py
index fc828b8f2a..e3943e933c 100644
--- a/src/calibre/gui2/book_details.py
+++ b/src/calibre/gui2/book_details.py
@@ -289,9 +289,11 @@ def details_context_menu_event(view, ev, book_info):  # {{{
                 except Exception:
                     field = value = book_id = None
                 if field:
-                    if author is None and (
-                            field in ('tags', 'series', 'publisher') or is_category(field)):
-                        menu.addAction(init_manage_action(book_info.manage_action, field, value))
+                    if author is None:
+                        if field in ('tags', 'series', 'publisher') or is_category(field):
+                            menu.addAction(init_manage_action(book_info.manage_action, field, value))
+                        elif field == 'identifiers':
+                            menu.addAction(book_info.edit_identifiers_action)
                     ac = book_info.remove_item_action
                     ac.data = (field, value, book_id)
                     ac.setText(_('Remove %s from this book') % value)
@@ -547,6 +549,7 @@ class BookInfo(QWebView):
     manage_category = pyqtSignal(object, object)
     open_fmt_with = pyqtSignal(int, object, object)
     edit_book = pyqtSignal(int, object)
+    edit_identifiers = pyqtSignal()
 
     def __init__(self, vertical, parent=None):
         QWebView.__init__(self, parent)
@@ -575,6 +578,8 @@ class BookInfo(QWebView):
         self.manage_action = QAction(self)
         self.manage_action.current_fmt = self.manage_action.current_url = None
         self.manage_action.triggered.connect(self.manage_action_triggered)
+        self.edit_identifiers_action = QAction(QIcon(I('identifiers.png')), _('Edit identifiers for this book'), self)
+        self.edit_identifiers_action.triggered.connect(self.edit_identifiers)
         self.remove_item_action = ac = QAction(QIcon(I('minus.png')), '...', self)
         ac.data = (None, None, None)
         ac.triggered.connect(self.remove_item_triggered)
@@ -768,6 +773,7 @@ class BookDetails(QWidget):  # {{{
     cover_removed = pyqtSignal(object)
     view_device_book = pyqtSignal(object)
     manage_category = pyqtSignal(object, object)
+    edit_identifiers = pyqtSignal()
     open_fmt_with = pyqtSignal(int, object, object)
     edit_book = pyqtSignal(int, object)
 
@@ -846,6 +852,7 @@ class BookDetails(QWidget):  # {{{
         self.book_info.compare_format.connect(self.compare_specific_format)
         self.book_info.copy_link.connect(self.copy_link)
         self.book_info.manage_category.connect(self.manage_category)
+        self.book_info.edit_identifiers.connect(self.edit_identifiers)
         self.setCursor(Qt.PointingHandCursor)
 
     def search_internet(self, data):
diff --git a/src/calibre/gui2/init.py b/src/calibre/gui2/init.py
index cc7bf94829..8cae6075de 100644
--- a/src/calibre/gui2/init.py
+++ b/src/calibre/gui2/init.py
@@ -684,6 +684,7 @@ class LayoutMixin(object):  # {{{
         self.book_details.view_device_book.connect(
                 self.iactions['View'].view_device_book)
         self.book_details.manage_category.connect(self.manage_category_triggerred)
+        self.book_details.edit_identifiers.connect(self.edit_identifiers_triggerred)
         self.book_details.compare_specific_format.connect(self.compare_format)
 
         m = self.library_view.model()
@@ -693,6 +694,17 @@ class LayoutMixin(object):  # {{{
                     self.library_view.currentIndex())
         self.library_view.setFocus(Qt.OtherFocusReason)
 
+    def edit_identifiers_triggerred(self):
+        book_id = self.library_view.current_book
+        db = self.current_db.new_api
+        identifiers = db.field_for('identifiers', book_id, default_value={})
+        from calibre.gui2.metadata.basic_widgets import Identifiers
+        d = Identifiers(identifiers, self)
+        if d.exec_() == d.Accepted:
+            identifiers = d.get_identifiers()
+            db.set_field('identifiers', {book_id: identifiers})
+            self.iactions['Edit Metadata'].refresh_books_after_metadata_edit({book_id})
+
     def manage_category_triggerred(self, field, value):
         if field and value:
             if field == 'authors':