From 0b04ea9ffd9a96575059603f74057ba7e768f09d Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Fri, 29 Jan 2010 10:54:44 -0700 Subject: [PATCH] Fix #4693 (Bulk edit metadata - can not set rating to 0 stars) --- src/calibre/gui2/dialogs/metadata_bulk.py | 6 +----- src/calibre/gui2/dialogs/metadata_bulk.ui | 9 +++++++++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/calibre/gui2/dialogs/metadata_bulk.py b/src/calibre/gui2/dialogs/metadata_bulk.py index d76d8136db..46342c8a88 100644 --- a/src/calibre/gui2/dialogs/metadata_bulk.py +++ b/src/calibre/gui2/dialogs/metadata_bulk.py @@ -20,10 +20,8 @@ class MetadataBulkDialog(QDialog, Ui_MetadataBulkDialog): self.db = db self.ids = [ db.id(r) for r in rows] self.write_series = False - self.write_rating = False self.changed = False QObject.connect(self.button_box, SIGNAL("accepted()"), self.sync) - QObject.connect(self.rating, SIGNAL('valueChanged(int)'), self.rating_changed) self.tags.update_tags_cache(self.db.all_tags()) self.remove_tags.update_tags_cache(self.db.all_tags()) @@ -99,7 +97,7 @@ class MetadataBulkDialog(QDialog, Ui_MetadataBulkDialog): aus = unicode(self.author_sort.text()) if aus and self.author_sort.isEnabled(): self.db.set_author_sort(id, aus, notify=False) - if self.write_rating: + if self.rating.value() != -1: self.db.set_rating(id, 2*self.rating.value(), notify=False) pub = unicode(self.publisher.text()) if pub: @@ -134,5 +132,3 @@ class MetadataBulkDialog(QDialog, Ui_MetadataBulkDialog): def series_changed(self): self.write_series = True - def rating_changed(self): - self.write_rating = True diff --git a/src/calibre/gui2/dialogs/metadata_bulk.ui b/src/calibre/gui2/dialogs/metadata_bulk.ui index 0fdb36b717..1a38568b60 100644 --- a/src/calibre/gui2/dialogs/metadata_bulk.ui +++ b/src/calibre/gui2/dialogs/metadata_bulk.ui @@ -96,12 +96,21 @@ QAbstractSpinBox::PlusMinus + + No change + stars + + -1 + 5 + + -1 +