Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add a comment about not using the Metadata class, and why

Browse Source
This commit is contained in:
Charles Haley 2010-09-05 11:01:55 +01:00
parent b603a761fb
commit 0ba513e287
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/calibre/library/server/mobile.py
View File

@ -199,6 +199,10 @@ class MobileServer(object):
CKEYS = [key for key in sorted(CFM.get_custom_fields(), CKEYS = [key for key in sorted(CFM.get_custom_fields(),
cmp=lambda x,y: cmp(CFM[x]['name'].lower(), cmp=lambda x,y: cmp(CFM[x]['name'].lower(),
CFM[y]['name'].lower()))] CFM[y]['name'].lower()))]
# This method uses its own book dict, not the Metadata dict. The loop
# below could be changed to use db.get_metadata instead of reading
# info directly from the record made by the view, but it doesn't seem
# worth it at the moment.
books = [] books = []
for record in items[(start-1):(start-1)+num]: for record in items[(start-1):(start-1)+num]:
book = {'formats':record[FM['formats']], 'size':record[FM['size']]} book = {'formats':record[FM['formats']], 'size':record[FM['size']]}

7
src/calibre/library/server/xml.py
View File

@ -66,6 +66,10 @@ class XMLServer(object):
return x.decode(preferred_encoding, 'replace') return x.decode(preferred_encoding, 'replace')
return unicode(x) return unicode(x)
# This method uses its own book dict, not the Metadata dict. The loop
# below could be changed to use db.get_metadata instead of reading
# info directly from the record made by the view, but it doesn't seem
# worth it at the moment.
for record in items[start:start+num]: for record in items[start:start+num]:
kwargs = {} kwargs = {}
aus = record[FM['authors']] if record[FM['authors']] else __builtin__._('Unknown') aus = record[FM['authors']] if record[FM['authors']] else __builtin__._('Unknown')
@ -138,6 +142,3 @@ class XMLServer(object):
return etree.tostring(ans, encoding='utf-8', pretty_print=True, return etree.tostring(ans, encoding='utf-8', pretty_print=True,
xml_declaration=True) xml_declaration=True)