From 10b738b5334bc6e6fac34bf51231d42536b075a0 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Fri, 4 Feb 2022 16:08:04 +0530 Subject: [PATCH] Remove coloring of splitter handles It's inconsistent to have this in one dialog in the application and no where else. If needed, this should be implemented in the calibre style application wide. --- src/calibre/gui2/metadata/single.py | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/calibre/gui2/metadata/single.py b/src/calibre/gui2/metadata/single.py index d351593a1b..f18d1eada1 100644 --- a/src/calibre/gui2/metadata/single.py +++ b/src/calibre/gui2/metadata/single.py @@ -13,7 +13,7 @@ from qt.core import ( QApplication, QDialog, QDialogButtonBox, QFrame, QGridLayout, QGroupBox, QHBoxLayout, QIcon, QInputDialog, QKeySequence, QMenu, QPushButton, QScrollArea, QShortcut, QSize, QSizePolicy, QSpacerItem, QSplitter, Qt, QTabWidget, - QToolButton, QVBoxLayout, QWidget, pyqtSignal, QPalette + QToolButton, QVBoxLayout, QWidget, pyqtSignal ) from calibre.constants import ismacos @@ -743,13 +743,6 @@ class Splitter(QSplitter): return QSplitter.resizeEvent(self, ev) -def color_splitter_handle(splitter): - # Slightly color the splitter handle. The Base color role takes light and - # dark mode into effect. - c = splitter.palette().color(QPalette.ColorRole.Base) - splitter.setStyleSheet("QSplitter::Handle { background: %s }"%c.name()) - - class MetadataSingleDialog(MetadataSingleDialogBase): # {{{ def do_layout(self): @@ -806,7 +799,6 @@ class MetadataSingleDialog(MetadataSingleDialogBase): # {{{ tl.addWidget(self.formats_manager, 0, 6, 3, 1) self.splitter = Splitter(Qt.Orientation.Horizontal, self) - color_splitter_handle(self.splitter) self.splitter.addWidget(self.cover) self.splitter.frame_resized.connect(self.cover.frame_resized) l.addWidget(self.splitter) @@ -1047,7 +1039,6 @@ class MetadataSingleDialogAlt1(MetadataSingleDialogBase): # {{{ wgl.addWidget(self.formats_manager) self.splitter = QSplitter(Qt.Orientation.Horizontal, tab1) - color_splitter_handle(self.splitter) tab1.l.addWidget(self.splitter) self.splitter.addWidget(self.cover) self.splitter.addWidget(wsp) @@ -1224,7 +1215,6 @@ class MetadataSingleDialogAlt2(MetadataSingleDialogBase): # {{{ self.formats_manager.formats.setMaximumWidth(10000) self.formats_manager.formats.setIconSize(QSize(32, 32)) main_splitter.addWidget(cover_and_formats) - color_splitter_handle(main_splitter) def save_widget_settings(self): gprefs['all_on_one_metadata_splitter_1_state'] = bytearray(self.metadata_splitter.saveState())