E-book viewer: Fix a few settings such as pages per screen and header/footers not being saved in profiles

This commit is contained in:
Kovid Goyal 2024-03-11 08:52:30 +05:30
parent 88d926143e
commit 11e4edf56d
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
2 changed files with 5 additions and 1 deletions

View File

@ -217,7 +217,7 @@ def deep_eq(a, b):
if ka.length is not Object.keys(b).length:
return False
for key in ka:
if not deep_eq(a[ka], b[ka]):
if not deep_eq(a[key], b[key]):
return False
return True
@ -283,6 +283,8 @@ def settings_for_reader_profile(sd):
if curval[key] is standalone_reader_defaults[key]:
v'delete curval[key]'
if setting_name is 'columns_per_screen':
print(1111111, is_set, metadata.category, metadata.disallowed_in_profile, curval, metadata.default, deep_eq(curval, metadata.default))
if not is_set or metadata.category is not 'read_book' or metadata.disallowed_in_profile or deep_eq(curval, metadata.default):
return False
return True

View File

@ -4,6 +4,7 @@ from __python__ import bound_methods, hash_literals
from testing import assert_equal, test
from utils import fmt_sidx, human_readable, rating_to_stars
from session import deep_eq
@test
@ -12,3 +13,4 @@ def misc_utils():
assert_equal(fmt_sidx(10), 'X')
assert_equal(fmt_sidx(1.2), '1.20')
assert_equal(list(map(human_readable, [1, 1024.0, 1025, 1024*1024*2.3])), ["1 B", "1 KB", "1 KB", "2.3 MB"])
assert_equal(False, deep_eq({"portrait":0, "landscape":0}, {"landscape":3, "portrait":0}))