From 123991aea51113193ce6af1261831bebeeaa019b Mon Sep 17 00:00:00 2001 From: John Schember Date: Mon, 5 Sep 2011 07:36:02 -0400 Subject: [PATCH] Fix for issue #816616: PDF Output Too many open files. --- src/calibre/ebooks/pdf/writer.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/calibre/ebooks/pdf/writer.py b/src/calibre/ebooks/pdf/writer.py index dc7f2edba9..ebe6533419 100644 --- a/src/calibre/ebooks/pdf/writer.py +++ b/src/calibre/ebooks/pdf/writer.py @@ -198,9 +198,10 @@ class PDFWriter(QObject): # {{{ try: outPDF = PdfFileWriter(title=self.metadata.title, author=self.metadata.author) for item in self.combine_queue: - inputPDF = PdfFileReader(open(item, 'rb')) - for page in inputPDF.pages: - outPDF.addPage(page) + with open(item, 'rb') as item_stream: + inputPDF = PdfFileReader(item_stream) + for page in inputPDF.pages: + outPDF.addPage(page) outPDF.write(self.out_stream) finally: self._delete_tmpdir()