From 12f75ddaf86e89c03013c75531aa1b5f25f7409a Mon Sep 17 00:00:00 2001
From: Charles Haley <>
Date: Sun, 26 Sep 2010 13:56:31 +0100
Subject: [PATCH] Note why we don't do a join where we should.

---
 src/calibre/gui2/library/models.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/calibre/gui2/library/models.py b/src/calibre/gui2/library/models.py
index b908019bcb..ff6d8b70f0 100644
--- a/src/calibre/gui2/library/models.py
+++ b/src/calibre/gui2/library/models.py
@@ -155,10 +155,14 @@ class BooksModel(QAbstractTableModel): # {{{
         self.database_changed.emit(db)
         if self.cover_cache is not None:
             self.cover_cache.stop()
+            # Would like to to a join here, but the thread might be waiting to
+            # do something on the GUI thread. Deadlock.
         self.cover_cache = CoverCache(db, FunctionDispatcher(self.db.cover))
         self.cover_cache.start()
         if self.metadata_backup is not None:
             self.metadata_backup.stop()
+            # Would like to to a join here, but the thread might be waiting to
+            # do something on the GUI thread. Deadlock.
         self.metadata_backup = MetadataBackup(db)
         self.metadata_backup.start()
         def refresh_cover(event, ids):