From 130e6d964997baf8a81179ab8ac4509b727b6fc1 Mon Sep 17 00:00:00 2001 From: Charles Haley Date: Sat, 1 Mar 2014 20:34:36 +0100 Subject: [PATCH] 1) Fix crash that is triggered by apps not using caching. 2) Don't refresh the GUI when requesting the transfer of unchanged metadata to the device. --- src/calibre/devices/smart_device_app/driver.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/calibre/devices/smart_device_app/driver.py b/src/calibre/devices/smart_device_app/driver.py index 392c86209b..1bc025b3cb 100644 --- a/src/calibre/devices/smart_device_app/driver.py +++ b/src/calibre/devices/smart_device_app/driver.py @@ -1251,7 +1251,7 @@ class SMART_DEVICE_APP(DeviceConfig, DevicePlugin): book = self.json_codec.raw_to_book(result, SDBook, self.PREFIX) book.set('_is_read_', result.get('_is_read_', None)) book.set('_is_read_changed_', result.get('_is_read_changed_', None)) - book.set('_last_read_date_', r.get('_last_read_date_', None)) + book.set('_last_read_date_', result.get('_last_read_date_', None)) bl.add_book(book, replace_metadata=True) if '_new_book_' in result: book.set('_new_book_', True) @@ -1512,7 +1512,7 @@ class SMART_DEVICE_APP(DeviceConfig, DevicePlugin): book.set('_force_send_metadata_', True) self._debug('special update book', book.get('title', 'huh?'), 'to', calibre_val) - return set(id_) + return set() # Both values are None. Do nothing return None