Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Prevent mem-leak in buttons

Browse Source 
Event handler should not have a reference to the DOM node in its context
This commit is contained in:
Kovid Goyal 2015-11-12 11:58:52 +05:30
parent 6f263dd3fc
commit 191381f7da
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pyj/widgets.pyj
View File

@ -13,7 +13,7 @@ def create_button(text, icon=None, action=None, tooltip=None):
text = '\xa0' + text text = '\xa0' + text
ans = E.button(E.i(class_=cls), text, class_='calibre-push-button', type='button', title=tooltip or '') ans = E.button(E.i(class_=cls), text, class_='calibre-push-button', type='button', title=tooltip or '')
if action is not None: if action is not None:
ans.addEventListener('click', def(event): event.preventDefault(), action(event, ans);) ans.addEventListener('click', def(event): event.preventDefault(), action(event);)
return ans return ans
create_button.style = build_rule('button.calibre-push-button', create_button.style = build_rule('button.calibre-push-button',