Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-06-23 15:30:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix #1899300 [Right click on a tag that has a '&' or ';' the symbol shows it as an underline in the context menu](https://bugs.launchpad.net/calibre/+bug/1899300)

Browse Source
This commit is contained in:
Kovid Goyal 2020-10-11 09:18:13 +05:30
parent 83d9f0946b
commit 1a8fde19c9
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/calibre/gui2/book_details.py
View File

@ -90,11 +90,15 @@ def is_category(field):
return field in {x[0] for x in find_categories(fm) if fm.is_custom_field(x[0])} return field in {x[0] for x in find_categories(fm) if fm.is_custom_field(x[0])}
def escape_for_menu(x):
return x.replace('&', '&&')
def init_manage_action(ac, field, value): def init_manage_action(ac, field, value):
from calibre.library.field_metadata import category_icon_map from calibre.library.field_metadata import category_icon_map
ic = category_icon_map.get(field) or 'blank.png' ic = category_icon_map.get(field) or 'blank.png'
ac.setIcon(QIcon(I(ic))) ac.setIcon(QIcon(I(ic)))
ac.setText(_('Manage %s') % value) ac.setText(_('Manage %s') % escape_for_menu(value))
ac.current_fmt = field, value ac.current_fmt = field, value
return ac return ac
@ -104,7 +108,7 @@ def init_find_in_tag_browser(menu, ac, field, value):
hidden_cats = get_gui().tags_view.model().hidden_categories hidden_cats = get_gui().tags_view.model().hidden_categories
if field not in hidden_cats: if field not in hidden_cats:
ac.setIcon(QIcon(I('search.png'))) ac.setIcon(QIcon(I('search.png')))
ac.setText(_('Find %s in the Tag browser') % value) ac.setText(_('Find %s in the Tag browser') % escape_for_menu(value))
ac.current_fmt = field, value ac.current_fmt = field, value
menu.addAction(ac) menu.addAction(ac)
@ -291,7 +295,7 @@ def add_item_specific_entries(menu, data, book_info):
init_find_in_tag_browser(menu, find_action, field, value) init_find_in_tag_browser(menu, find_action, field, value)
ac = book_info.remove_item_action ac = book_info.remove_item_action
ac.data = (field, remove_value, book_id) ac.data = (field, remove_value, book_id)
ac.setText(_('Remove %s from this book') % value) ac.setText(_('Remove %s from this book') % escape_for_menu(value))
menu.addAction(ac) menu.addAction(ac)
return search_internet_added return search_internet_added