From 1ac36a1dc6343c3d89febbd313c50e21a9e4f9de Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Fri, 21 Nov 2014 18:28:48 +0530 Subject: [PATCH] Adding books: Delete the cover tempfile immediately after adding, should reduce tmp usage a bit --- src/calibre/gui2/add.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/calibre/gui2/add.py b/src/calibre/gui2/add.py index b228ca6b18..7dea376ab8 100644 --- a/src/calibre/gui2/add.py +++ b/src/calibre/gui2/add.py @@ -331,6 +331,7 @@ class Adder(QObject): self.merged_books.add((mi.title, ' & '.join(mi.authors))) seen_fmts = set() replace = gprefs['automerge'] == 'overwrite' + cover_removed = False for identical_book_id in identical_book_ids: ib_fmts = {fmt.upper() for fmt in self.db.formats(identical_book_id)} seen_fmts |= ib_fmts @@ -343,6 +344,12 @@ class Adder(QObject): # arguably put only the duplicate formats, but no real harm is # done by having all formats self.add_book(mi, cover_path, paths) + cover_removed = True + if not cover_removed and cover_path: + try: + os.remove(cover_path) + except Exception: + pass def add_book(self, mi, cover_path, paths): if DEBUG: @@ -352,6 +359,10 @@ class Adder(QObject): if cover_path: with open(cover_path, 'rb') as f: cdata = f.read() + try: + os.remove(cover_path) + except Exception: + pass book_id = self.dbref().create_book_entry(mi, cover=cdata) self.added_book_ids.add(book_id) except Exception: