Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Bug #2019457: Tag browser - transient right click error.

Browse Source 
The search category can disappear from field_metadata. Perhaps other dynamic categories can as well. The implication is that dynamic categories are being removed, but how that would happen is a mystery. I suspect a plugin is operating on the "real" field_metadata instead of a copy, thereby changing the dict used by the rest of calibre.

 As it can happen, to avoid key errors check that a category exists before offering to unhide it.
This commit is contained in:
Charles Haley 2023-05-21 09:28:29 +01:00
parent b82b2fde97
commit 1e78b9fe7c
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/calibre/gui2/tag_browser/view.py
View File

@ -722,7 +722,16 @@ class TagsView(QTreeView): # {{{
added_show_hidden_categories = True
m = self.context_menu.addMenu(_('Show category'))
m.setIcon(QIcon.ic('plus.png'))
for col in sorted(self.hidden_categories,
# The search category can disappear from field_metadata. Perhaps
# other dynamic categories can as well. The implication is that
# dynamic categories are being removed, but how that would
# happen is a mystery. I suspect a plugin is operating on the
# "real" field_metadata instead of a copy, thereby changing the
# dict used by the rest of calibre.
#
# As it can happen, to avoid key errors check that a category
# exists before offering to unhide it.
for col in sorted((c for c in self.hidden_categories if c in self.db.field_metadata),
key=lambda x: sort_key(self.db.field_metadata[x]['name'])):
ac = m.addAction(self.db.field_metadata[col]['name'],
partial(self.context_menu_handler, action='show', category=col))