Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Address code review comments

Browse Source
This commit is contained in:
Steffen Siebert 2023-02-19 13:28:31 +01:00
parent a26ba63e1f
commit 1f2b890f10
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/calibre/customize/__init__.py
View File

@ -390,8 +390,9 @@ class FileTypePlugin(Plugin): # {{{
def postconvert(self, book_id, book_format, db):
'''
Called post conversion, i.e., after the book file has been added to the database. It is
useful for modifying the book record based on the contents of the newly added file.
Called post conversion, i.e., after the book file has been added to the database. Note that
it is run after a conversion only, not after a book is added. It is useful for modifying
the book record based on the contents of the newly added file.
:param book_id: Database id of the added book.
:param book_format: The file type of the book that was added.
@ -401,8 +402,10 @@ class FileTypePlugin(Plugin): # {{{
def postdelete(self, book_id, book_format, db):
'''
Called post deletion, i.e., after the book file has been deleted from the database. It is
useful for modifying the book record based on the format of the deleted file.
Called post deletion, i.e., after the book file has been deleted from the database. Note
that it is not run when a book record is deleted, only when one or more formats from the
book are deleted. It is useful for modifying the book record based on the format of the
deleted file.
:param book_id: Database id of the added book.
:param book_format: The file type of the book that was added.

3
src/calibre/srv/convert.py
View File

@ -7,7 +7,7 @@ import shutil
import tempfile
from threading import Lock
from calibre.customize.ui import input_profiles, output_profiles
from calibre.customize.ui import input_profiles, output_profiles, run_plugins_on_postconvert
from calibre.db.errors import NoSuchBook
from calibre.srv.changes import formats_added
from calibre.srv.errors import BookNotFound, HTTPNotFound
@ -194,6 +194,7 @@ def conversion_status(ctx, rd, job_id):
except NoSuchBook:
raise HTTPNotFound(
f'book_id {job_status.book_id} not found in library')
run_plugins_on_postconvert(db, job_status.book_id, fmt)
formats_added({job_status.book_id: (fmt,)})
ans['size'] = os.path.getsize(job_status.output_path)
ans['fmt'] = fmt