From 2c6c222adf676a00d441b24988f1bd929d39a572 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sun, 31 Jan 2010 14:59:23 -0700 Subject: [PATCH] Fix #4731 ("Reset cover to default" does not work properly) --- Changelog.yaml | 3 +++ src/calibre/gui2/dialogs/metadata_single.py | 7 +++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Changelog.yaml b/Changelog.yaml index 7c5644fd63..6ca5b37926 100644 --- a/Changelog.yaml +++ b/Changelog.yaml @@ -51,6 +51,9 @@ - title: "Fix error while sending book with non-ascii character in title/author to device on linux" tickets: [4690] + - title: "Fix reset cover in edit meta information dialog does not actually remove cover" + tickets: [4731] + new recipes: - title: Kamera Bild author: Darko Miletic diff --git a/src/calibre/gui2/dialogs/metadata_single.py b/src/calibre/gui2/dialogs/metadata_single.py index 846851fd21..f385b76c4c 100644 --- a/src/calibre/gui2/dialogs/metadata_single.py +++ b/src/calibre/gui2/dialogs/metadata_single.py @@ -653,8 +653,11 @@ class MetadataSingleDialog(ResizableDialog, Ui_MetadataSingleDialog): d = d + self.local_timezone_offset self.db.set_timestamp(self.id, d) - if self.cover_changed and self.cover_data is not None: - self.db.set_cover(self.id, self.cover_data) + if self.cover_changed: + if self.cover_data is not None: + self.db.set_cover(self.id, self.cover_data) + else: + self.db.remove_cover(self.id) except IOError, err: if err.errno == 13: # Permission denied fname = err.filename if err.filename else 'file'