From 7445bae81fa03579c74c8537b78011624e476a8f Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Tue, 15 Jun 2010 09:29:29 -0600 Subject: [PATCH 1/2] ... --- src/calibre/gui2/tag_view.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/calibre/gui2/tag_view.py b/src/calibre/gui2/tag_view.py index fc20d98279..ce37b44f79 100644 --- a/src/calibre/gui2/tag_view.py +++ b/src/calibre/gui2/tag_view.py @@ -26,18 +26,13 @@ from calibre.gui2.dialogs.edit_authors_dialog import EditAuthorsDialog class TagDelegate(QItemDelegate): - def __init__(self, parent): - QItemDelegate.__init__(self, parent) - self._parent = parent - self.icon = QIcon(I('star.png')) - def paint(self, painter, option, index): item = index.internalPointer() if item.type != TagTreeItem.TAG: QItemDelegate.paint(self, painter, option, index) return r = option.rect - model = self._parent.model() + model = self.parent().model() icon = model.data(index, Qt.DecorationRole).toPyObject() painter.save() if item.tag.state != 0 or not config['show_avg_rating'] or \ From 1efe9d8d1d1a50de04b2d471e385d256618374ef Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Tue, 15 Jun 2010 09:51:11 -0600 Subject: [PATCH 2/2] Better rendering of avg rating indication --- src/calibre/gui2/tag_view.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/calibre/gui2/tag_view.py b/src/calibre/gui2/tag_view.py index ce37b44f79..5e5393fdc4 100644 --- a/src/calibre/gui2/tag_view.py +++ b/src/calibre/gui2/tag_view.py @@ -39,7 +39,9 @@ class TagDelegate(QItemDelegate): item.tag.avg_rating is None: icon.paint(painter, r, Qt.AlignLeft) else: - icon.paint(painter, r, Qt.AlignLeft, mode=QIcon.Disabled) + painter.setOpacity(0.3) + icon.paint(painter, r, Qt.AlignLeft) + painter.setOpacity(1) rating = item.tag.avg_rating painter.setClipRect(r.left(), r.bottom()-int(r.height()*(rating/5.0)), r.width(), r.height())