From 2f55fd3a843e5278b640ba253b21dbe489f0de9d Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Mon, 7 Aug 2023 09:08:18 +0530 Subject: [PATCH] DRYer --- src/calibre/gui2/actions/edit_metadata.py | 4 +++- src/calibre/gui2/metadata/single.py | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/calibre/gui2/actions/edit_metadata.py b/src/calibre/gui2/actions/edit_metadata.py index 03738d8200..08e441a722 100644 --- a/src/calibre/gui2/actions/edit_metadata.py +++ b/src/calibre/gui2/actions/edit_metadata.py @@ -33,6 +33,8 @@ from calibre.utils.icu import sort_key from calibre.utils.localization import ngettext from polyglot.builtins import iteritems +DATA_FILES_ICON_NAME = 'unpack-book.png' + class EditMetadataAction(InterfaceAction): @@ -106,7 +108,7 @@ class EditMetadataAction(InterfaceAction): shortcut=_('M'), triggered=self.merge_books) self.action_merge.setMenu(mb) self.action_manage_data_files = cm( - 'manage_data_files', _('Manage data files'), icon='unpack-book.png', triggered=self.manage_data_files) + 'manage_data_files', _('Manage data files'), icon=DATA_FILES_ICON_NAME, triggered=self.manage_data_files) self.qaction.triggered.connect(self.edit_metadata) ac = QAction(_('Copy URL to show book in calibre'), self.gui) diff --git a/src/calibre/gui2/metadata/single.py b/src/calibre/gui2/metadata/single.py index 28334d52aa..70275de46b 100644 --- a/src/calibre/gui2/metadata/single.py +++ b/src/calibre/gui2/metadata/single.py @@ -92,7 +92,8 @@ class MetadataSingleDialogBase(QDialog): self.prev_button = QPushButton(QIcon.ic('back.png'), _('Previous'), self) self.prev_button.setShortcut(QKeySequence('Alt+Left')) - self.data_files_button = QPushButton(QIcon.ic('unpack-book.png'), _('Data files'), self) + from calibre.gui2.actions.edit_metadata import DATA_FILES_ICON_NAME + self.data_files_button = QPushButton(QIcon.ic(DATA_FILES_ICON_NAME), _('Data files'), self) self.data_files_button.setShortcut(QKeySequence('Alt+Space')) self.data_files_button.setToolTip(_('Manage the extra data files associated with this book [{}]').format( self.data_files_button.shortcut().toString(QKeySequence.SequenceFormat.NativeText)))