Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-07 18:24:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup Manage value icons sub-menu

Browse Source 
Use the value name when available. It's true that the sub-menu contains
entries to manage overall icons as well, but the common use case is
changing the icon for the particular value, so use the value name in the
menu entry.
This commit is contained in:
Kovid Goyal 2025-01-16 19:20:03 +05:30
parent 39e17d55e3
commit 3331d35a49
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/calibre/gui2/tag_browser/view.py
View File

@ -1250,39 +1250,39 @@ class TagsView(QTreeView): # {{{
key='search_folder', category=_('Saved searches folder')))
sm.setIcon(QIcon.ic('edit-clear.png'))
if key not in ('search', 'formats') and not key.startswith('@'):
im = cm.addMenu(_('Manage value icons'))
def get_rule_data(tag, key):
if tag is None:
return (None, None, None)
name = tag.original_name
cat_rules = self._model.value_icons.get(key, {})
icon_name, for_child = cat_rules.get(name, (None, None))
return (name, icon_name, for_child)
return name, icon_name, for_child
name, icon_name, for_child = get_rule_data(tag, key)
for_name = name or _('this value')
im = cm.addMenu(_('Manage icon for {}').format(for_name))
if name is not None:
im.addSection(_('Current value: {}').format(name))
else:
im.addSection(_('No value available'))
im.addSeparator
ma = im.addAction(_('Choose an icon for this value but not its children'),
ma = im.addAction(_('Choose an icon for {} but not its children').format(for_name),
partial(self.context_menu_handler, action='set_icon',
key=key, index=index, category=category, extra=(None, False)))
ma.setEnabled(name is not None)
ma = im.addAction(_('Choose an icon for this value and children'),
ma = im.addAction(_('Choose an icon for {} and its children').format(for_name),
partial(self.context_menu_handler, action='set_icon',
key=key, index=index, category=category, extra=(None, True)))
ma.setEnabled(name is not None)
im.addSeparator()
ma = im.addAction(_('Use the existing icon for this value but not its children'),
ma = im.addAction(_('Use the existing icon for {} but not its children').format(for_name),
partial(self.context_menu_handler, action='set_icon',
key=key, index=index, category=category, extra=(icon_name, False)))
ma.setEnabled(icon_name is not None and for_child)
ma = im.addAction(_('Use the existing icon for this value and its children'),
ma = im.addAction(_('Use the existing icon for {} and its children').format(for_name),
partial(self.context_menu_handler, action='set_icon',
key=key, index=index, category=category, extra=(icon_name, True)))
ma.setEnabled(icon_name is not None and not for_child)
im.addAction(_('Use the default icon for this value'),
im.addAction(_('Use the default icon for {}').format(for_name),
partial(self.context_menu_handler, action='clear_icon',
key=key, index=index, category=category))
im.addSection(_('Defaults'))