Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Tag mapper: Special case case-change rules for performance. See #1513330 (Freezes loading books)

Browse Source
This commit is contained in:
Kovid Goyal 2015-11-05 13:06:48 +05:30
parent 08f6eb1c1f
commit 3378bf6af4
1 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/calibre/ebooks/metadata/tag_mapper.py
View File

@ -4,7 +4,6 @@
from __future__ import (unicode_literals, division, absolute_import, from __future__ import (unicode_literals, division, absolute_import,
print_function) print_function)
import regex import regex
from collections import deque from collections import deque
@ -39,9 +38,9 @@ def apply_rules(tag, rules):
maxiter = 20 maxiter = 20
while tags and maxiter > 0: while tags and maxiter > 0:
tag = tags.popleft() tag = tags.popleft()
ltag = icu_lower(tag)
maxiter -= 1 maxiter -= 1
for rule, matches in rules: for rule, matches in rules:
ltag = icu_lower(tag)
if matches(ltag): if matches(ltag):
ac = rule['action'] ac = rule['action']
if ac == 'remove': if ac == 'remove':
@ -55,8 +54,21 @@ def apply_rules(tag, rules):
else: else:
tag = rule['replace'] tag = rule['replace']
if ',' in tag: if ',' in tag:
tags.extendleft(x.strip() for x in reversed(tag.split(','))) replacement_tags = []
self_added = False
for rtag in (x.strip() for x in tag.split(',')):
if icu_lower(rtag) == ltag:
if not self_added:
ans.append(rtag)
self_added = True
else:
replacement_tags.append(rtag)
tags.extendleft(replacement_tags)
else: else:
if icu_lower(tag) == ltag:
# Case change or self replacement
ans.append(tag)
break
tags.appendleft(tag) tags.appendleft(tag)
break break
else: # no rule matched, default keep else: # no rule matched, default keep
@ -107,3 +119,11 @@ def test():
{'action':'replace', 'query':'t2', 'match_type':'one_of', 'replace':'t1'}, {'action':'replace', 'query':'t2', 'match_type':'one_of', 'replace':'t1'},
] ]
assert set(map_tags(['t1', 't2'], rules)) == {'t1', 't2'} assert set(map_tags(['t1', 't2'], rules)) == {'t1', 't2'}
rules = [
{'action':'replace', 'query':'a', 'match_type':'one_of', 'replace':'A'},
]
assert map_tags(['a', 'b'], rules) == ['A', 'b']
rules = [
{'action':'replace', 'query':'a,b', 'match_type':'one_of', 'replace':'A,B'},
]
assert map_tags(['a', 'b'], rules) == ['A', 'B']