Get rid of busy loop retries for connecting to inspector dock

This commit is contained in:
Kovid Goyal 2019-10-05 11:10:38 +05:30
parent d2d188215c
commit 34d3011726
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
2 changed files with 1 additions and 9 deletions

View File

@ -320,17 +320,8 @@ class Inspector(QWidget):
self.view = None
self.layout = QHBoxLayout(self)
self.layout.setContentsMargins(0, 0, 0, 0)
self.connection_attempts = 0
QTimer.singleShot(0, self.connect_to_dock)
def connect_to_dock(self):
if 'inspector-dock' not in actions:
self.connection_attempts += 1
if self.connection_attempts < 1000:
QTimer.singleShot(10, self.connect_to_dock)
else:
print('Failed to connect to inspector dock')
return
ac = actions['inspector-dock']
ac.toggled.connect(self.visibility_changed)
if ac.isChecked():

View File

@ -748,6 +748,7 @@ class Main(MainWindow):
self.preview.inspector.setParent(d)
self.addDockWidget(Qt.BottomDockWidgetArea, d)
d.close() # By default the inspector window is closed
QTimer.singleShot(10, self.preview.inspector.connect_to_dock)
d = create(_('Table of Contents'), 'toc-viewer')
d.setAllowedAreas(Qt.LeftDockWidgetArea | Qt.RightDockWidgetArea | Qt.BottomDockWidgetArea | Qt.TopDockWidgetArea)