Change the application name set in Qt to calibre from libprs500. Fixes #1623397 [[Enhancement] Change APP_UID from 'libprs500' to 'Calibre'](https://bugs.launchpad.net/calibre/+bug/1623397)

I looked into the code and the only place QSettings appears to be used
is to store the last used settings of the Qt WebKit Inspector. I think
it is acceptable to lose those settings to get rid of libprs500,
especially since some X11 implementations brokenly display the app name
in their user interfaces.
This commit is contained in:
Kovid Goyal 2016-09-14 18:29:33 +05:30
parent cb8738ca36
commit 34ebda86a5
5 changed files with 9 additions and 15 deletions

View File

@ -12,11 +12,9 @@ from PyQt5.Qt import (
QDesktopServices, QFileDialog, QFileIconProvider, QSettings, QIcon, QDesktopServices, QFileDialog, QFileIconProvider, QSettings, QIcon,
QApplication, QDialog, QUrl, QFont, QFontDatabase, QLocale, QFontInfo) QApplication, QDialog, QUrl, QFont, QFontDatabase, QLocale, QFontInfo)
ORG_NAME = 'KovidsBrain'
APP_UID = 'libprs500'
from calibre import prints from calibre import prints
from calibre.constants import (islinux, iswindows, isbsd, isfrozen, isosx, from calibre.constants import (islinux, iswindows, isbsd, isfrozen, isosx,
plugins, config_dir, filesystem_encoding, isxp, DEBUG) plugins, config_dir, filesystem_encoding, isxp, DEBUG, __version__, __appname__ as APP_UID)
from calibre.utils.config import Config, ConfigProxy, dynamic, JSONConfig from calibre.utils.config import Config, ConfigProxy, dynamic, JSONConfig
from calibre.ebooks.metadata import MetaInformation from calibre.ebooks.metadata import MetaInformation
from calibre.utils.date import UNDEFINED_DATE from calibre.utils.date import UNDEFINED_DATE
@ -886,6 +884,10 @@ class Application(QApplication):
# control this, if needed. # control this, if needed.
# Could have options: auto, off, 1.25, 1.5, 1.75, 2, 2.25, 2.5 # Could have options: auto, off, 1.25, 1.5, 1.75, 2, 2.25, 2.5
QApplication.setAttribute(Qt.AA_EnableHighDpiScaling, True) QApplication.setAttribute(Qt.AA_EnableHighDpiScaling, True)
QApplication.setOrganizationName('calibre-ebook.com')
QApplication.setOrganizationDomain(QApplication.organizationName())
QApplication.setApplicationVersion(__version__)
QApplication.setApplicationName(APP_UID)
QApplication.__init__(self, qargs) QApplication.__init__(self, qargs)
self.setAttribute(Qt.AA_UseHighDpiPixmaps) self.setAttribute(Qt.AA_UseHighDpiPixmaps)
if DEBUG and not headless: if DEBUG and not headless:

View File

@ -8,7 +8,7 @@ from PyQt5.Qt import (
from calibre import __appname__, setup_cli_handlers, islinux, isbsd from calibre import __appname__, setup_cli_handlers, islinux, isbsd
from calibre.ebooks.lrf.lrfparser import LRFDocument from calibre.ebooks.lrf.lrfparser import LRFDocument
from calibre.gui2 import ORG_NAME, APP_UID, error_dialog, \ from calibre.gui2 import error_dialog, \
config, choose_files, Application config, choose_files, Application
from calibre.gui2.dialogs.conversion_error import ConversionErrorDialog from calibre.gui2.dialogs.conversion_error import ConversionErrorDialog
from calibre.gui2.lrf_renderer.main_ui import Ui_MainWindow from calibre.gui2.lrf_renderer.main_ui import Ui_MainWindow
@ -307,8 +307,6 @@ def main(args=sys.argv, logger=None):
override = 'calibre-lrf-viewer' if islinux else None override = 'calibre-lrf-viewer' if islinux else None
app = Application(args, override_program_name=override) app = Application(args, override_program_name=override)
app.setWindowIcon(QIcon(I('viewer.png'))) app.setWindowIcon(QIcon(I('viewer.png')))
QCoreApplication.setOrganizationName(ORG_NAME)
QCoreApplication.setApplicationName(APP_UID)
opts = normalize_settings(parser, opts) opts = normalize_settings(parser, opts)
stream = open(args[1], 'rb') if len(args) > 1 else None stream = open(args[1], 'rb') if len(args) > 1 else None
main = file_renderer(stream, opts, logger=logger) main = file_renderer(stream, opts, logger=logger)

View File

@ -13,7 +13,7 @@ from calibre.constants import (iswindows, __appname__, isosx, DEBUG, islinux,
filesystem_encoding, get_portable_base) filesystem_encoding, get_portable_base)
from calibre.utils.ipc import gui_socket_address, RC from calibre.utils.ipc import gui_socket_address, RC
from calibre.gui2 import ( from calibre.gui2 import (
ORG_NAME, APP_UID, initialize_file_icon_provider, Application, choose_dir, initialize_file_icon_provider, Application, choose_dir,
error_dialog, question_dialog, gprefs, setup_gui_option_parser) error_dialog, question_dialog, gprefs, setup_gui_option_parser)
from calibre.gui2.main_window import option_parser as _option_parser from calibre.gui2.main_window import option_parser as _option_parser
from calibre.gui2.splash_screen import SplashScreen from calibre.gui2.splash_screen import SplashScreen
@ -95,8 +95,6 @@ def init_qt(args):
if os.path.isdir(libpath): if os.path.isdir(libpath):
prefs.set('library_path', os.path.abspath(libpath)) prefs.set('library_path', os.path.abspath(libpath))
prints('Using library at', prefs['library_path']) prints('Using library at', prefs['library_path'])
QCoreApplication.setOrganizationName(ORG_NAME)
QCoreApplication.setApplicationName(APP_UID)
override = 'calibre-gui' if islinux else None override = 'calibre-gui' if islinux else None
app = Application(args, override_program_name=override) app = Application(args, override_program_name=override)
app.file_event_hook = EventAccumulator() app.file_event_hook = EventAccumulator()

View File

@ -11,7 +11,7 @@ import sys, os, importlib, time
from PyQt5.Qt import QIcon from PyQt5.Qt import QIcon
from calibre.constants import islinux, iswindows from calibre.constants import islinux, iswindows
from calibre.gui2 import Application, ORG_NAME, APP_UID, setup_gui_option_parser, decouple, set_gui_prefs from calibre.gui2 import Application, setup_gui_option_parser, decouple, set_gui_prefs
from calibre.ptempfile import reset_base_dir from calibre.ptempfile import reset_base_dir
from calibre.utils.config import OptionParser from calibre.utils.config import OptionParser
@ -66,8 +66,6 @@ def _run(args, notify=None):
app.file_event_hook = EventAccumulator() app.file_event_hook = EventAccumulator()
app.load_builtin_fonts() app.load_builtin_fonts()
app.setWindowIcon(QIcon(I('tweak.png'))) app.setWindowIcon(QIcon(I('tweak.png')))
Application.setOrganizationName(ORG_NAME)
Application.setApplicationName(APP_UID)
main = Main(opts, notify=notify) main = Main(opts, notify=notify)
main.set_exception_handler() main.set_exception_handler()
main.show() main.show()

View File

@ -13,7 +13,7 @@ from calibre.gui2.viewer.ui import Main as MainWindow
from calibre.gui2.viewer.toc import TOC from calibre.gui2.viewer.toc import TOC
from calibre.gui2.widgets import ProgressIndicator from calibre.gui2.widgets import ProgressIndicator
from calibre.gui2 import ( from calibre.gui2 import (
Application, ORG_NAME, APP_UID, choose_files, info_dialog, error_dialog, Application, choose_files, info_dialog, error_dialog,
open_url, setup_gui_option_parser) open_url, setup_gui_option_parser)
from calibre.ebooks.oeb.iterator.book import EbookIterator from calibre.ebooks.oeb.iterator.book import EbookIterator
from calibre.constants import islinux, filesystem_encoding, DEBUG, iswindows from calibre.constants import islinux, filesystem_encoding, DEBUG, iswindows
@ -1227,8 +1227,6 @@ def main(args=sys.argv):
app.file_event_hook = acc app.file_event_hook = acc
app.load_builtin_fonts() app.load_builtin_fonts()
app.setWindowIcon(QIcon(I('viewer.png'))) app.setWindowIcon(QIcon(I('viewer.png')))
QApplication.setOrganizationName(ORG_NAME)
QApplication.setApplicationName(APP_UID)
if vprefs['singleinstance']: if vprefs['singleinstance']:
try: try: