Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Edit book: Fix a crash when editing CSS files caused by a behavior change in Qt 5.13. Fixes #1846760 [ebook editor crashes out when scrolling](https://bugs.launchpad.net/calibre/+bug/1846760)

Browse Source 
Apparently, if a QTextFormat.FormatRange object is garbage collected by
python it is no longer safe to use a previously stored reference to it
QTextFormat object
This commit is contained in:
Kovid Goyal 2019-10-14 17:26:51 +05:30
parent 12485fef82
commit 420b2f65b4
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/calibre/gui2/tweak_book/editor/text.py
View File

@ -741,12 +741,10 @@ class TextEdit(PlainTextEdit):
if r.start <= pos <= r.start + r.length and r.format.property(SYNTAX_PROPERTY): if r.start <= pos <= r.start + r.length and r.format.property(SYNTAX_PROPERTY):
return r return r
def syntax_format_for_cursor(self, cursor):
return getattr(self.syntax_range_for_cursor(cursor), 'format', None)
def show_tooltip(self, ev): def show_tooltip(self, ev):
c = self.cursorForPosition(ev.pos()) c = self.cursorForPosition(ev.pos())
fmt = self.syntax_format_for_cursor(c) fmt_range = self.syntax_range_for_cursor(c)
fmt = getattr(fmt_range, 'format', None)
if fmt is not None: if fmt is not None:
tt = unicode_type(fmt.toolTip()) tt = unicode_type(fmt.toolTip())
if tt: if tt: