Fixed resource leak in HelloWorld plugin?

This commit is contained in:
Joseph Fox-Rabinovitz 2021-01-05 16:02:52 -06:00 committed by GitHub
parent 8da7110fc8
commit 487a598d29
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -22,11 +22,11 @@ class HelloWorld(FileTypePlugin):
def run(self, path_to_ebook): def run(self, path_to_ebook):
from calibre.ebooks.metadata.meta import get_metadata, set_metadata from calibre.ebooks.metadata.meta import get_metadata, set_metadata
file = open(path_to_ebook, 'r+b') with open(path_to_ebook, 'r+b') as file:
ext = os.path.splitext(path_to_ebook)[-1][1:].lower() ext = os.path.splitext(path_to_ebook)[-1][1:].lower()
mi = get_metadata(file, ext) mi = get_metadata(file, ext)
mi.publisher = 'Hello World' mi.publisher = 'Hello World'
set_metadata(file, mi, ext) set_metadata(file, mi, ext)
return path_to_ebook return path_to_ebook