From 4a074eb2bf7a27d4787c2b3f49148ab4a99fe382 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 9 Oct 2019 11:34:34 +0530 Subject: [PATCH] Viewer: Fix preferences under Scrolling behavior not being saved correctly --- src/pyj/read_book/prefs/scrolling.pyj | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/pyj/read_book/prefs/scrolling.pyj b/src/pyj/read_book/prefs/scrolling.pyj index d136832916..96eebe56e6 100644 --- a/src/pyj/read_book/prefs/scrolling.pyj +++ b/src/pyj/read_book/prefs/scrolling.pyj @@ -54,8 +54,12 @@ develop = create_scrolling_panel def commit_scrolling(onchange): sd = get_session_data() container = get_container() + changed = False for control in container.querySelectorAll('input[name]'): name = control.getAttribute('name') val = control.checked - sd.set(name, None if val is defaults[name] else val) - onchange() + if val is not sd.get(name): + sd.set(name, val) + changed = True + if changed: + onchange()