Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Dont store reference to db on tag tree nodes

Browse Source 
This has the potential of preventing db garbage collection because of
reference cycles and there is no need since the current db is available
globally in the GUI. And we dont unnecessarily carry around an extra
reference on every node.
This commit is contained in:
Kovid Goyal 2025-01-21 18:53:44 +05:30
parent 2a3fdcc3d5
commit 4a77d39053
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/calibre/gui2/tag_browser/model.py
View File

@ -55,7 +55,6 @@ class TagTreeItem: # {{{
icon_config_dir = {}
file_icon_provider = None
eval_formatter = EvalFormatter()
database = None
def __init__(self, data=None, is_category=False, icon_map=None,
parent=None, tooltip=None, category_key=None, temporary=False,
@ -147,9 +146,11 @@ class TagTreeItem: # {{{
v = {'category': category, 'value': self.tag.original_name,
'count': getattr(self.tag, 'count', ''),
'avg_rating': getattr(self.tag, 'avg_rating', '')}
from calibre.gui2 import get_gui
db = get_gui().current_db
t = self.eval_formatter.safe_format(self.value_icons[category][TEMPLATE_ICON_INDICATOR][0],
v, 'VALUE_ICON_TEMPLATE_ERROR', {},
database=self.database)
database=db)
if t:
val_icon = (os.path.join('template_icons', t), False)
else:
@ -1487,7 +1488,6 @@ class TagsModel(QAbstractItemModel): # {{{
node.value_icons = self.value_icons
node.value_icon_cache = self.value_icon_cache
node.icon_config_dir = self.icon_config_dir
node.database = self.db
return node
def get_node(self, idx):