From 4dde757294e290c5a2ddb4afdf97fa583866c4e4 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Tue, 25 Aug 2009 18:23:25 -0600 Subject: [PATCH] IGN:Handle failure to find print version of articles more gracefully --- src/calibre/web/feeds/news.py | 3 +++ src/calibre/web/feeds/recipes/recipe_livemint.py | 5 +---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/calibre/web/feeds/news.py b/src/calibre/web/feeds/news.py index 91e00cc213..849a5be1ab 100644 --- a/src/calibre/web/feeds/news.py +++ b/src/calibre/web/feeds/news.py @@ -741,6 +741,9 @@ class BasicNewsRecipe(Recipe): url = self.print_version(article.url) except NotImplementedError: url = article.url + except: + self.log.exception('Failed to find print version for: '+article.url) + url = None if not url: continue func, arg = (self.fetch_embedded_article, article) if self.use_embedded_content else \ diff --git a/src/calibre/web/feeds/recipes/recipe_livemint.py b/src/calibre/web/feeds/recipes/recipe_livemint.py index 5813233b86..2461dde404 100644 --- a/src/calibre/web/feeds/recipes/recipe_livemint.py +++ b/src/calibre/web/feeds/recipes/recipe_livemint.py @@ -30,10 +30,7 @@ class LiveMint(BasicNewsRecipe): def print_version(self, url): link = url - try: - msoup = self.index_to_soup(link) - except: - return 'http://invalid_url_generated_by_calibre.com' + msoup = self.index_to_soup(link) mlink = msoup.find(attrs={'id':'ctl00_bodyplaceholdercontent_cntlArtTool_printUrl'}) if mlink: link = 'http://www.livemint.com/Articles/' + mlink['href'].rpartition('/Articles/')[2]