From 504501de7fe03890d4119f580633eeb9657526cc Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 16 Oct 2019 04:14:56 +0530 Subject: [PATCH] Revert workaround for Qt Bug that caused calibre to not start full screen in windows 10 tablet mode The bug has been fixed as of Qt 5.8 https://bugreports.qt.io/browse/QTBUG-56831 And maybe calling restoreGeometry() fter show will help with offscreen positioning in multi-monitor setups. --- src/calibre/gui2/ui.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/calibre/gui2/ui.py b/src/calibre/gui2/ui.py index c685edd63c..ce11877e2a 100644 --- a/src/calibre/gui2/ui.py +++ b/src/calibre/gui2/ui.py @@ -399,6 +399,8 @@ class Main(MainWindow, MainWindowMixin, DeviceMixin, EmailMixin, # {{{ if config['autolaunch_server']: self.start_content_server() + if show_gui: + self.show() self.read_settings() self.finalize_layout() @@ -418,10 +420,6 @@ class Main(MainWindow, MainWindowMixin, DeviceMixin, EmailMixin, # {{{ register_keyboard_shortcuts() self.keyboard.finalize() - if show_gui: - # Note this has to come after restoreGeometry() because of - # https://bugreports.qt.io/browse/QTBUG-56831 - self.show() if self.system_tray_icon is not None and self.system_tray_icon.isVisible() and opts.start_in_tray: self.hide_windows() self.auto_adder = AutoAdder(gprefs['auto_add_path'], self)