From 56f079a08e96cfa7b5cc3f06d5bb39fe0e3b45ac Mon Sep 17 00:00:00 2001 From: Charles Haley <> Date: Fri, 8 Oct 2010 09:52:34 +0100 Subject: [PATCH] Change add/delete to delete/add, just in case the add ends up creating another of what is being deleted. --- src/calibre/gui2/tag_view.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/calibre/gui2/tag_view.py b/src/calibre/gui2/tag_view.py index a054bb0645..88a9220024 100644 --- a/src/calibre/gui2/tag_view.py +++ b/src/calibre/gui2/tag_view.py @@ -836,11 +836,11 @@ class TagBrowserMixin(object): # {{{ rename_func = partial(db.rename_custom_item, label=cc_label) delete_func = partial(db.delete_custom_item_using_id, label=cc_label) if rename_func: + for item in to_delete: + delete_func(item) for text in to_rename: for old_id in to_rename[text]: rename_func(old_id, new_name=unicode(text)) - for item in to_delete: - delete_func(item) # Clean up everything, as information could have changed for many books. self.library_view.model().refresh()