Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

E-book viewer: Workaround bug in Chromium where getBoundingClientRect() fails sometimes leading to incorrect calculation of anchor positions. Fixes #2037543 [E-book viewer: incorrect ToC item is gets highlighted](https://bugs.launchpad.net/calibre/+bug/2037543)

Browse Source
This commit is contained in:
Kovid Goyal 2023-09-28 09:36:08 +05:30
parent 879ebdf68e
commit 597c47917f
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/pyj/read_book/paged_mode.pyj
View File

@ -848,12 +848,27 @@ def handle_gesture(gesture):
scroll_by_page(False, False)
def get_bounding_client_rect_using_offset_properties(elem):
ans = {'left': 0, 'top': 0, 'width': elem.offsetWidth, 'height': elem.offsetHeight, 'x': 0, 'y': 0}
while elem:
ans.left += elem.offsetLeft
ans.top += elem.offsetTop
elem = elem.offsetParent
ans.left -= window.scrollX
ans.top -= window.scrollTop
ans.x, ans.y = ans.left, ans.top
return ans
anchor_funcs = {
'pos_for_elem': def pos_for_elem(elem):
if not elem:
return 0
elem = scrollable_element(elem)
br = elem.getBoundingClientRect()
if br.left is 0 and br.top is 0 and br.width is 0 and br.height is 0:
# getBoundingClientRect() fails sometimes, see https://bugs.launchpad.net/calibre/+bug/2037543
br = get_bounding_client_rect_using_offset_properties(elem)
pos = scroll_viewport.viewport_to_document_inline(
scroll_viewport.rect_inline_start(br))
return column_at(pos)