From 5a404de21a083b416938ad559958a30d6f21e91c Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Thu, 24 Nov 2022 11:12:20 +0530 Subject: [PATCH] Merging books: Fix title sort not being updated when the title is updated. Fixes #1996802 [Merging book into Unknown doesn't copy title sort](https://bugs.launchpad.net/calibre/+bug/1996802) --- src/calibre/gui2/actions/edit_metadata.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/calibre/gui2/actions/edit_metadata.py b/src/calibre/gui2/actions/edit_metadata.py index af8e178626..c487d15ef5 100644 --- a/src/calibre/gui2/actions/edit_metadata.py +++ b/src/calibre/gui2/actions/edit_metadata.py @@ -716,8 +716,9 @@ class EditMetadataAction(InterfaceAction): dest_mi.comments = src_mi.comments else: dest_mi.comments = str(dest_mi.comments) + '\n\n' + str(src_mi.comments) - if src_mi.title and (not dest_mi.title or dest_mi.title == _('Unknown')): + if src_mi.title and dest_mi.is_null('title'): dest_mi.title = src_mi.title + dest_mi.title_sort = src_mi.title_sort if (src_mi.authors and src_mi.authors[0] != _('Unknown')) and (not dest_mi.authors or dest_mi.authors[0] == _('Unknown')): dest_mi.authors = src_mi.authors dest_mi.author_sort = src_mi.author_sort