Improved editing of dates for custom columns

src/calibre/gui2/custom_column_widgets.py

@@ -10,9 +10,10 @@ from functools import partial
 
 from PyQt4.Qt import QComboBox, QLabel, QSpinBox, QDoubleSpinBox, QDateEdit, \
         QDate, QGroupBox, QVBoxLayout, QPlainTextEdit, QSizePolicy, \
-        QSpacerItem, QIcon, QCheckBox, QWidget, QHBoxLayout, SIGNAL
+        QSpacerItem, QIcon, QCheckBox, QWidget, QHBoxLayout, SIGNAL, \
+        QPushButton
 
-from calibre.utils.date import qt_to_dt
+from calibre.utils.date import qt_to_dt, now
 from calibre.gui2.widgets import TagsLineEdit, EnComboBox
 from calibre.gui2 import UNDEFINED_QDATE
 from calibre.utils.config import tweaks
@@ -132,20 +133,30 @@ class DateEdit(QDateEdit):
 
     def focusInEvent(self, x):
         self.setSpecialValueText('')
+        QDateEdit.focusInEvent(self, x)
 
     def focusOutEvent(self, x):
         self.setSpecialValueText(_('Undefined'))
+        QDateEdit.focusOutEvent(self, x)
+
+    def set_to_today(self):
+        self.setDate(now())
 
 class DateTime(Base):
 
     def setup_ui(self, parent):
-        self.widgets = [QLabel('&'+self.col_metadata['name']+':', parent),
+        cm = self.col_metadata
-                DateEdit(parent)]
+        self.widgets = [QLabel('&'+cm['name']+':', parent), DateEdit(parent),
+            QLabel(''), QPushButton(_('Set \'%s\' to today')%cm['name'], parent)]
         w = self.widgets[1]
-        w.setDisplayFormat('dd MMM yyyy')
+        format = cm['display'].get('date_format','')
+        if not format:
+            format = 'dd MMM yyyy'
+        w.setDisplayFormat(format)
         w.setCalendarPopup(True)
         w.setMinimumDate(UNDEFINED_QDATE)
         w.setSpecialValueText(_('Undefined'))
+        self.widgets[3].clicked.connect(w.set_to_today)
 
     def setter(self, val):
         if val is None:
@@ -156,7 +167,7 @@ class DateTime(Base):
 
     def getter(self):
         val = self.widgets[1].date()
-        if val == UNDEFINED_QDATE:
+        if val <= UNDEFINED_QDATE:
             val = None
         else:
             val = qt_to_dt(val)

src/calibre/gui2/library/delegates.py

@@ -96,7 +96,7 @@ class DateDelegate(QStyledItemDelegate): # {{{
 
     def displayText(self, val, locale):
         d = val.toDate()
-        if d == UNDEFINED_QDATE:
+        if d <= UNDEFINED_QDATE:
             return ''
         return format_date(d.toPyDate(), 'dd MMM yyyy')
 
@@ -116,7 +116,7 @@ class PubDateDelegate(QStyledItemDelegate): # {{{
 
     def displayText(self, val, locale):
         d = val.toDate()
-        if d == UNDEFINED_QDATE:
+        if d <= UNDEFINED_QDATE:
             return ''
         format = tweaks['gui_pubdate_display_format']
         if format is None:
@@ -194,7 +194,7 @@ class CcDateDelegate(QStyledItemDelegate): # {{{
 
     def displayText(self, val, locale):
         d = val.toDate()
-        if d == UNDEFINED_QDATE:
+        if d <= UNDEFINED_QDATE:
             return ''
         return format_date(d.toPyDate(), self.format)
 
@@ -217,7 +217,7 @@ class CcDateDelegate(QStyledItemDelegate): # {{{
 
     def setModelData(self, editor, model, index):
         val = editor.date()
-        if val == UNDEFINED_QDATE:
+        if val <= UNDEFINED_QDATE:
             val = None
         model.setData(index, QVariant(val), Qt.EditRole)
 

src/calibre/gui2/library/models.py

@@ -1216,7 +1216,9 @@ class DeviceBooksModel(BooksModel): # {{{
         return done
 
     def set_editable(self, editable):
-        self.editable = editable
+        # Cannot edit if metadata is sent on connect. Reason: changes will
+        # revert to what is in the library on next connect.
+        self.editable = editable and prefs['manage_device_metadata']!='on_connect'
 
     def set_search_restriction(self, s):
         pass

src/calibre/library/caches.py

@@ -209,13 +209,13 @@ class ResultCache(SearchQueryParser):
         if query == 'false':
             for item in self._data:
                 if item is None: continue
-                if item[loc] is None or item[loc] == UNDEFINED_DATE:
+                if item[loc] is None or item[loc] <= UNDEFINED_DATE:
                     matches.add(item[0])
             return matches
         if query == 'true':
             for item in self._data:
                 if item is None: continue
-                if item[loc] is not None and item[loc] != UNDEFINED_DATE:
+                if item[loc] is not None and item[loc] > UNDEFINED_DATE:
                     matches.add(item[0])
             return matches