Fixes for Library Keyboard Shortcuts aren't disabled when location is device

https://bugs.launchpad.net/bugs/1793800

src/calibre/gui2/actions/__init__.py

@@ -143,6 +143,7 @@ class InterfaceAction(QObject):
         self.gui.addAction(self.qaction)
         self.gui.addAction(self.menuless_qaction)
         self.genesis()
+        self.location_selected('library')
 
     @property
     def unique_name(self):

src/calibre/gui2/actions/add_to_library.py

@@ -23,6 +23,7 @@ class AddToLibraryAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc != 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def add_books_to_library(self, *args):
         self.gui.iactions['Add Books'].add_books_from_device(

src/calibre/gui2/actions/catalog.py

@@ -29,6 +29,7 @@ class GenerateCatalogAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def generate_catalog(self):
         rows = self.gui.library_view.selectionModel().selectedRows()

src/calibre/gui2/actions/choose_library.py

@@ -401,6 +401,7 @@ class ChooseLibraryAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def rename_requested(self, name, location):
         LibraryDatabase = db_class()

src/calibre/gui2/actions/convert.py

@@ -69,6 +69,9 @@ class ConvertAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
+        for action in list(self.convert_menu.actions()):
+            action.setEnabled(enabled)
 
     def auto_convert(self, book_ids, on_card, format):
         previous = self.gui.library_view.currentIndex()

src/calibre/gui2/actions/copy_to_library.py

@@ -432,6 +432,7 @@ class CopyToLibraryAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def build_menus(self):
         self.menu.clear()

src/calibre/gui2/actions/device.py

@@ -163,6 +163,7 @@ class SendToDeviceAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def do_sync(self, *args):
         self.gui._sync_action_triggered()
@@ -189,6 +190,7 @@ class ConnectShareAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def set_state(self, device_connected, device):
         self.share_conn_menu.set_state(device_connected, device)

src/calibre/gui2/actions/edit_collections.py

@@ -23,6 +23,7 @@ class EditCollectionsAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc != 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def edit_collections(self, *args):
         oncard = None

src/calibre/gui2/actions/edit_metadata.py

@@ -77,7 +77,7 @@ class EditMetadataAction(InterfaceAction):
                 shortcut='Ctrl+D')
         self.metadata_menu = md
 
-        mb = QMenu()
+        self.metamerge_menu = mb = QMenu()
         cm2 = partial(self.create_menu_action, mb)
         cm2('merge delete', _('Merge into first selected book - delete others'),
                 triggered=self.merge_books)
@@ -102,7 +102,9 @@ class EditMetadataAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
-        self.action_merge.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
+        for action in self.metamerge_menu.actions() + self.metadata_menu.actions():
+            action.setEnabled(enabled)
 
     def copy_metadata(self):
         rows = self.gui.library_view.selectionModel().selectedRows()

src/calibre/gui2/actions/fetch_news.py

@@ -23,6 +23,7 @@ class FetchNewsAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def genesis(self):
         self.conversion_jobs = {}

src/calibre/gui2/actions/mark_books.py

@@ -95,6 +95,9 @@ class MarkBooksAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
+        for action in self.menu.actions():
+            action.setEnabled(enabled)
 
     def toggle_selected(self):
         book_ids = self._get_selected_ids()

src/calibre/gui2/actions/match_books.py

@@ -27,6 +27,7 @@ class MatchBookAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc != 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def match_books_in_library(self, *args):
         view = self.gui.current_view()

src/calibre/gui2/actions/open.py

@@ -23,5 +23,6 @@ class OpenFolderAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
 

src/calibre/gui2/actions/polish.py

@@ -435,6 +435,7 @@ class PolishAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def get_books_for_polishing(self):
         rows = [r.row() for r in

src/calibre/gui2/actions/random.py

@@ -25,6 +25,7 @@ class PickRandomAction(InterfaceAction):
     def location_selected(self, loc):
         enabled = loc == 'library'
         self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def pick_random(self):
         pick = random.randint(0, self.gui.library_view.model().rowCount(None))

src/calibre/gui2/actions/sort.py

@@ -41,7 +41,9 @@ class SortByAction(InterfaceAction):
         self.qaction.menu().aboutToShow.connect(self.about_to_show)
 
     def location_selected(self, loc):
-        self.qaction.setEnabled(loc == 'library')
+        enabled = loc == 'library'
+        self.qaction.setEnabled(enabled)
+        self.menuless_qaction.setEnabled(enabled)
 
     def about_to_show(self):
         self.update_menu()