From 5db33faeb8a2ceaeec15212bf92ff235c2a9b231 Mon Sep 17 00:00:00 2001
From: Kovid Goyal <kovid@kovidgoyal.net>
Date: Thu, 6 Apr 2017 11:47:00 +0530
Subject: [PATCH] Encode local state using # instead of ? in URLS

Needed for appcache (appcache caches URLs with different ? query
parameters separately).

Also probably semantically more correct, since
the query data represents local state.
---
 src/pyj/book_list/router.pyj | 9 +++++++--
 src/pyj/utils.pyj            | 4 ++--
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/pyj/book_list/router.pyj b/src/pyj/book_list/router.pyj
index b2481434ea..b2e963409d 100644
--- a/src/pyj/book_list/router.pyj
+++ b/src/pyj/book_list/router.pyj
@@ -2,7 +2,7 @@
 # License: GPL v3 Copyright: 2017, Kovid Goyal <kovid at kovidgoyal.net>
 from __python__ import hash_literals, bound_methods
 
-from ajax import encode_query
+from ajax import encode_query as ajax_encode_query
 
 from book_list.constants import read_book_container_id, book_list_container_id
 from book_list.globals import get_current_query
@@ -54,11 +54,16 @@ def open_book(book_id, fmt, library_id=None, replace=False):
     push_state({'book_id':book_id, 'fmt':fmt, 'library_id':library_id}, replace=replace, mode=read_book_mode)
 
 
+def encode_query(query):
+    ans = ajax_encode_query(query)
+    return '#' + ans[1:]
+
+
 def push_state(query, replace=False, mode='book_list', call_handler=True):
     query = {k:query[k] for k in query}
     if mode is not 'book_list':
         query.mode = mode
-    query = encode_query(query) or '?'
+    query = encode_query(query)
     if replace:
         window.history.replaceState(None, '', query)
     else:
diff --git a/src/pyj/utils.pyj b/src/pyj/utils.pyj
index e89131886d..fa128c05ed 100644
--- a/src/pyj/utils.pyj
+++ b/src/pyj/utils.pyj
@@ -29,12 +29,12 @@ def parse_url_params(url=None, allow_multiple=False):
     url = url or window.location.href
     if cache[url]:
         return parse_url_params.cache[url]
-    qs = url.indexOf('?')
+    qs = url.indexOf('#')
     ans = {}
     if qs < 0:
         cache[url] = ans
         return ans
-    q = url.slice(qs + 1, ((url.indexOf('#') + 1) or (url.length + 1)))
+    q = url.slice(qs + 1, (url.length + 1))
     if not q:
         cache[url] = ans
         return ans