From 63f5be20c86232e99a38fcaff7a6b7fa45ad8b4b Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sat, 13 Apr 2013 20:32:32 +0530 Subject: [PATCH] Edit metadata dialog: Dont allow choosing svg images for covers --- src/calibre/gui2/__init__.py | 5 +++-- src/calibre/gui2/metadata/basic_widgets.py | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/calibre/gui2/__init__.py b/src/calibre/gui2/__init__.py index 4a6ff9bb93..3a532ec2c0 100644 --- a/src/calibre/gui2/__init__.py +++ b/src/calibre/gui2/__init__.py @@ -716,10 +716,11 @@ def choose_save_file(window, name, title, filters=[], all_files=True): ans = ans[0] return ans -def choose_images(window, name, title, select_only_single_file=True): +def choose_images(window, name, title, select_only_single_file=True, + formats=('png', 'gif', 'jpg', 'jpeg', 'svg')): mode = QFileDialog.ExistingFile if select_only_single_file else QFileDialog.ExistingFiles fd = FileDialog(title=title, name=name, - filters=[('Images', ['png', 'gif', 'jpeg', 'jpg', 'svg'])], + filters=[('Images', list(formats))], parent=window, add_all_files_filter=False, mode=mode, ) fd.setParent(None) diff --git a/src/calibre/gui2/metadata/basic_widgets.py b/src/calibre/gui2/metadata/basic_widgets.py index 5e031a4b2c..984986affe 100644 --- a/src/calibre/gui2/metadata/basic_widgets.py +++ b/src/calibre/gui2/metadata/basic_widgets.py @@ -927,9 +927,9 @@ class Cover(ImageView): # {{{ return sz def select_cover(self, *args): - files = choose_images(self, 'change cover dialog', - _('Choose cover for ') + - self.dialog.title.current_val) + files = choose_images( + self, 'change cover dialog', _('Choose cover for ') + self.dialog.title.current_val, + formats=('png', 'gif', 'jpg', 'jpeg')) if not files: return _file = files[0]