From 64265d04654ef0f0ffe972e114c1d120734d63b1 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 1 Feb 2012 12:30:38 +0530 Subject: [PATCH] Fix regression in 0.8.34 that broke recipes that used skip_ad_pages() but not get_browser(). Fixes #923724 (Recipes and cookies) --- src/calibre/web/feeds/news.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/calibre/web/feeds/news.py b/src/calibre/web/feeds/news.py index 6f2331a5dd..dff5735cdd 100644 --- a/src/calibre/web/feeds/news.py +++ b/src/calibre/web/feeds/news.py @@ -545,8 +545,10 @@ class BasicNewsRecipe(Recipe): ''' if re.match(r'\w+://', url_or_raw): # We may be called in a thread (in the skip_ad_pages method), so - # clone the browser to be safe - br = self.cloned_browser + # clone the browser to be safe. We cannot use self.cloned_browser + # as it may or may not actually clone the browser, depending on if + # the recipe implements get_browser() or not + br = self.clone_browser(self.browser) open_func = getattr(br, 'open_novisit', br.open) with closing(open_func(url_or_raw)) as f: _raw = f.read()