Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Preferences->Adding books, detect when the user specifies a test expression with no file extension and popup a warning

Browse Source
This commit is contained in:
Kovid Goyal 2011-08-29 10:06:04 -06:00
parent f1a0c539ed
commit 67271f66f3
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/calibre/gui2/widgets.py
View File

@ -3,7 +3,7 @@ __copyright__ = '2008, Kovid Goyal <kovid at kovidgoyal.net>'
''' '''
Miscellaneous widgets used in the GUI Miscellaneous widgets used in the GUI
''' '''
import re, traceback import re, traceback, os
from PyQt4.Qt import (QIcon, QFont, QLabel, QListWidget, QAction, from PyQt4.Qt import (QIcon, QFont, QLabel, QListWidget, QAction,
QListWidgetItem, QTextCharFormat, QApplication, QListWidgetItem, QTextCharFormat, QApplication,
@ -15,7 +15,8 @@ from PyQt4.Qt import (QIcon, QFont, QLabel, QListWidget, QAction,
QMenu, QStringListModel, QCompleter, QStringList, QMenu, QStringListModel, QCompleter, QStringList,
QTimer, QRect, QFontDatabase, QGraphicsView) QTimer, QRect, QFontDatabase, QGraphicsView)
from calibre.gui2 import NONE, error_dialog, pixmap_to_data, gprefs from calibre.gui2 import (NONE, error_dialog, pixmap_to_data, gprefs,
warning_dialog)
from calibre.gui2.filename_pattern_ui import Ui_Form from calibre.gui2.filename_pattern_ui import Ui_Form
from calibre import fit_image from calibre import fit_image
from calibre.ebooks import BOOK_EXTENSIONS from calibre.ebooks import BOOK_EXTENSIONS
@ -96,13 +97,21 @@ class FilenamePattern(QWidget, Ui_Form): # {{{
def do_test(self): def do_test(self):
from calibre.ebooks.metadata.meta import metadata_from_filename from calibre.ebooks.metadata.meta import metadata_from_filename
fname = unicode(self.filename.text())
ext = os.path.splitext(fname)[1][1:].lower()
if ext not in BOOK_EXTENSIONS:
return warning_dialog(self, _('Test name invalid'),
_('The name <b>%r</b> does not appear to end with a'
' file extension. The name must end with a file '
' extension like .epub or .mobi')%fname, show=True)
try: try:
pat = self.pattern() pat = self.pattern()
except Exception as err: except Exception as err:
error_dialog(self, _('Invalid regular expression'), error_dialog(self, _('Invalid regular expression'),
_('Invalid regular expression: %s')%err).exec_() _('Invalid regular expression: %s')%err).exec_()
return return
mi = metadata_from_filename(unicode(self.filename.text()), pat) mi = metadata_from_filename(fname, pat)
if mi.title: if mi.title:
self.title.setText(mi.title) self.title.setText(mi.title)
else: else: