Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Linux: Disable support for touch based scrolling of the book list, because of bugs in Qt that break other functionality. Fixes #1707282 [Regression: Can't drag books to tag browser categories anymore](https://bugs.launchpad.net/calibre/+bug/1707282)

Browse Source
This commit is contained in:
Kovid Goyal 2017-07-29 13:07:41 +05:30
parent 4441539375
commit 69059f51d6
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/calibre/gui2/library/alternate_views.py
View File

@ -22,7 +22,7 @@ from PyQt5.Qt import (
qBlue, QItemSelectionModel, QIcon, QFont, QMouseEvent) qBlue, QItemSelectionModel, QIcon, QFont, QMouseEvent)
from calibre import fit_image, prints, prepare_string_for_xml, human_readable from calibre import fit_image, prints, prepare_string_for_xml, human_readable
from calibre.constants import DEBUG, config_dir, islinux from calibre.constants import DEBUG, config_dir, islinux, iswindows, isosx
from calibre.ebooks.metadata import fmt_sidx, rating_to_stars from calibre.ebooks.metadata import fmt_sidx, rating_to_stars
from calibre.utils import join_with_timeout from calibre.utils import join_with_timeout
from calibre.utils.monotonic import monotonic from calibre.utils.monotonic import monotonic
@ -626,6 +626,12 @@ class CoverDelegate(QStyledItemDelegate):
# }}} # }}}
has_gestures = iswindows or isosx
# Enabling gesture support on X11 causes Qt to send fake touch events when
# right clicking/dragging with the mouse, which breaks things, for example:
# https://bugs.launchpad.net/bugs/1707282
def send_click(view, pos, button=Qt.LeftButton, double_click=False): def send_click(view, pos, button=Qt.LeftButton, double_click=False):
if double_click: if double_click:
ev = QMouseEvent(QEvent.MouseButtonDblClick, pos, button, button, QApplication.keyboardModifiers()) ev = QMouseEvent(QEvent.MouseButtonDblClick, pos, button, button, QApplication.keyboardModifiers())
@ -656,6 +662,7 @@ def handle_gesture(ev, view):
def setup_gestures(view): def setup_gestures(view):
if has_gestures:
v = view.viewport() v = view.viewport()
view.scroller = QScroller.grabGesture(v, QScroller.TouchGesture) view.scroller = QScroller.grabGesture(v, QScroller.TouchGesture)
v.grabGesture(Qt.TapGesture) v.grabGesture(Qt.TapGesture)
@ -664,6 +671,8 @@ def setup_gestures(view):
def gesture_viewport_event(view, ev): def gesture_viewport_event(view, ev):
if not has_gestures:
return
et = ev.type() et = ev.type()
if et in (QEvent.MouseButtonPress, QEvent.MouseMove, QEvent.MouseButtonRelease, QEvent.MouseButtonDblClick): if et in (QEvent.MouseButtonPress, QEvent.MouseMove, QEvent.MouseButtonRelease, QEvent.MouseButtonDblClick):
if ev.source() in (Qt.MouseEventSynthesizedBySystem, Qt.MouseEventSynthesizedByQt): if ev.source() in (Qt.MouseEventSynthesizedBySystem, Qt.MouseEventSynthesizedByQt):