From 69cf3d345abf27c4dd43be519c0939dfb978f19b Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Thu, 18 Apr 2019 02:47:29 -0400 Subject: [PATCH] py3: fix sort method being called with implicit parameters Passing None as the first argument in order to not use cmp, is not portable. --- src/calibre/gui2/store/search/models.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/calibre/gui2/store/search/models.py b/src/calibre/gui2/store/search/models.py index 7f21d130b6..8a1d0738c0 100644 --- a/src/calibre/gui2/store/search/models.py +++ b/src/calibre/gui2/store/search/models.py @@ -291,9 +291,9 @@ class Matches(QAbstractItemModel): if not self.matches: return descending = order == Qt.DescendingOrder - self.all_matches.sort(None, - lambda x: sort_key(unicode_type(self.data_as_text(x, col))), - descending) + self.all_matches.sort( + key=lambda x: sort_key(unicode_type(self.data_as_text(x, col))), + reverse=descending) self.reorder_matches() if reset: self.beginResetModel(), self.endResetModel()