Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2026-03-22 09:27:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

Ensure shelf_added is called even when no books are present

Browse Source
This commit is contained in:
Kovid Goyal 2026-01-20 10:43:02 +05:30
parent abdfa7e364
commit 6cbaba36cd
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/calibre/gui2/library/bookshelf_view.py
View File

@ -1174,6 +1174,8 @@ class BookCase(QObject):
self.using_page_counts = spine_size_template in ('{pages}', 'pages')
if len(self.items) > 1:
self.shelf_added.emit(self.items[-2], self.items[-1])
else:
self.shelf_added.emit(None, None)
def visual_row_cmp(self, a: int, b: int) -> int:
' Compares if a or b (book_row numbers) is visually before the other in left-to-right top-to-bottom order'
@ -1680,7 +1682,7 @@ class BookshelfView(MomentumScrollMixin, QAbstractScrollArea):
else:
self.invalidate(clear_spine_width_cache=True)
def on_shelf_layout_done(self, books: CaseItem, shelf: CaseItem) -> None:
def on_shelf_layout_done(self, books: CaseItem | None, shelf: CaseItem | None) -> None:
if self.view_is_visible():
if self.bookcase.layout_finished:
self.update_scrollbar_ranges()
@ -1689,12 +1691,13 @@ class BookshelfView(MomentumScrollMixin, QAbstractScrollArea):
self.scroll_to_current_after_layout = False
if (idx := self.currentIndex()).isValid():
self.scrollTo(idx)
y = books.start_y
height = books.height + shelf.height
r = self.viewport().rect()
r.moveTop(self.verticalScrollBar().value())
if self.bookcase.layout_finished or r.intersects(QRect(r.left(), y, r.width(), height)):
self.update_viewport()
if books is not None and shelf is not None:
y = books.start_y
height = books.height + shelf.height
r = self.viewport().rect()
r.moveTop(self.verticalScrollBar().value())
if self.bookcase.layout_finished or r.intersects(QRect(r.left(), y, r.width(), height)):
self.update_viewport()
@property
def shelves_per_screen(self) -> int: