Remove tag_order kludge

src/calibre/devices/interface.py

@@ -293,8 +293,7 @@ class DevicePlugin(Plugin):
         put the book. len(metadata) == len(files). Apart from the regular
         cover (path to cover), there may also be a thumbnail attribute, which should
         be used in preference. The thumbnail attribute is of the form
-        (width, height, cover_data as jpeg). In addition the MetaInformation
-        objects can have a tag_order attribute.
+        (width, height, cover_data as jpeg).
         '''
         raise NotImplementedError()
 

src/calibre/ebooks/metadata/__init__.py

@@ -258,7 +258,7 @@ class MetaInformation(object):
                   'series', 'series_index', 'tags', 'rating', 'isbn', 'language',
                   'application_id', 'manifest', 'toc', 'spine', 'guide', 'cover',
                   'book_producer', 'timestamp', 'lccn', 'lcc', 'ddc', 'pubdate',
-                  'rights', 'publication_type', 'uuid', 'tag_order',
+                  'rights', 'publication_type', 'uuid'
                   ):
             prints(x, getattr(self, x, 'None'))
 
@@ -278,7 +278,7 @@ class MetaInformation(object):
                      'isbn', 'application_id', 'manifest', 'spine', 'toc',
                      'cover', 'language', 'guide', 'book_producer',
                      'timestamp', 'lccn', 'lcc', 'ddc', 'pubdate', 'rights',
-                     'publication_type', 'uuid', 'tag_order'):
+                     'publication_type', 'uuid'):
             if hasattr(mi, attr):
                 val = getattr(mi, attr)
                 if val is not None:

src/calibre/gui2/library/models.py

@@ -343,9 +343,6 @@ class BooksModel(QAbstractTableModel): # {{{
         ans = []
         for id in ids:
             mi = self.db.get_metadata(id, index_is_id=True, get_cover=True)
-            if mi.series is not None:
-                mi.tag_order = { mi.series: self.db.books_in_series_of(id,
-                    index_is_id=True)}
             ans.append(mi)
         return ans