From 70d96e7a07cd8ee57603fae136c811f4642d6f0d Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Fri, 21 Feb 2014 13:14:01 +0530 Subject: [PATCH] Fix #1282898 [Broken Edit Metadata in Bulk commits 1.25.0](https://bugs.launchpad.net/calibre/+bug/1282898) --- src/calibre/gui2/dialogs/metadata_bulk.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/calibre/gui2/dialogs/metadata_bulk.py b/src/calibre/gui2/dialogs/metadata_bulk.py index e111562d2f..4545a5ba28 100644 --- a/src/calibre/gui2/dialogs/metadata_bulk.py +++ b/src/calibre/gui2/dialogs/metadata_bulk.py @@ -943,8 +943,13 @@ class MetadataBulkDialog(ResizableDialog, Ui_MetadataBulkDialog): self.save_state() if len(self.ids) < 1: return QDialog.accept(self) + try: + source = self.s_r_sf_itemdata(None) + except: + source = '' + do_sr = source and self.s_r_obj - if self.s_r_error is not None: + if self.s_r_error is not None and do_sr: error_dialog(self, _('Search/replace invalid'), _('Search pattern is invalid: %s')%self.s_r_error.message, show=True) @@ -1007,8 +1012,6 @@ class MetadataBulkDialog(ResizableDialog, Ui_MetadataBulkDialog): pubdate, adddate, do_title_sort, languages, clear_languages, restore_original, self.comments) - source = self.s_r_sf_itemdata(None) - do_sr = source and self.s_r_obj self.set_field_calls = defaultdict(dict) bb = MyBlockingBusy(args, self.ids, self.db, self.refresh_books, getattr(self, 'custom_column_widgets', []),