Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Metadata editor: Fix removing formatting for comments not removing background colors. Fixes #1258975 [Clear formatting button in comment editor does not clear span codes](https://bugs.launchpad.net/calibre/+bug/1258975)

Browse Source
This commit is contained in:
Kovid Goyal 2013-12-11 21:38:09 +05:30
parent 7f5e1082d1
commit 7296dfda74
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/calibre/gui2/comments_editor.py
View File

@ -310,6 +310,23 @@ class EditorWidget(QWebView): # {{{
frame.evaluateJavaScript(js) frame.evaluateJavaScript(js)
def remove_format_cleanup(self): def remove_format_cleanup(self):
# WebKit (the version in Qt 4.8.x at least) does not remove background
# colors, see https://bugs.webkit.org/show_bug.cgi?id=101682
self.page().mainFrame().evaluateJavaScript(
'''
var sel = window.getSelection();
if (sel.rangeCount >= 1) {
var node = sel.getRangeAt(0).commonAncestorContainer;
if (node.style.backgroundColor && node.style.backgroundColor != 'transparent') node.style.backgroundColor = 'transparent';
var descendants = node.getElementsByTagName('*');
for (var i = 0; i < descendants.length; i++) {
var s = descendants[i].style;
if (s.backgroundColor && s.backgroundColor != 'transparent')
s.backgroundColor = 'transparent';
}
}
''')
self.html = self.html self.html = self.html
@dynamic_property @dynamic_property
@ -736,7 +753,8 @@ if __name__ == '__main__':
w = Editor() w = Editor()
w.resize(800, 600) w.resize(800, 600)
w.show() w.show()
w.html = '<b>testing</b>' w.html = '''<span style="background-color: rgb(0, 255, 255); ">He hadn't
set out to have an <em>affair</em>, <span style="font-style:italic; background-color:red">much</span> less a long-term, devoted one.</span>'''
app.exec_() app.exec_()
# print w.html # print w.html