Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge from trunk

Browse Source
This commit is contained in:
Charles Haley 2011-03-12 23:55:08 +00:00
commit 72f9249a8f
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/calibre/ebooks/metadata/book/base.py
View File

@ -92,7 +92,9 @@ class Metadata(object):
def is_null(self, field): def is_null(self, field):
null_val = NULL_VALUES.get(field, None) null_val = NULL_VALUES.get(field, None)
val = getattr(self, field, None) val = getattr(self, field, None)
return val is None or val == null_val if val is False or val in (0, 0.0):
return True
return not val or val == null_val
def __getattribute__(self, field): def __getattribute__(self, field):
_data = object.__getattribute__(self, '_data') _data = object.__getattribute__(self, '_data')

8
src/calibre/library/database2.py
View File

@ -2360,7 +2360,7 @@ class LibraryDatabase2(LibraryDatabase, SchemaUpgrade, CustomColumns):
@param tags: list of strings @param tags: list of strings
@param append: If True existing tags are not removed @param append: If True existing tags are not removed
''' '''
if tags is None: if not tags:
tags = [] tags = []
if not append: if not append:
self.conn.execute('DELETE FROM books_tags_link WHERE book=?', (id,)) self.conn.execute('DELETE FROM books_tags_link WHERE book=?', (id,))
@ -2512,7 +2512,7 @@ class LibraryDatabase2(LibraryDatabase, SchemaUpgrade, CustomColumns):
self.notify('metadata', [id]) self.notify('metadata', [id])
def set_rating(self, id, rating, notify=True, commit=True): def set_rating(self, id, rating, notify=True, commit=True):
if rating is None: if not rating:
rating = 0 rating = 0
rating = int(rating) rating = int(rating)
self.conn.execute('DELETE FROM books_ratings_link WHERE book=?',(id,)) self.conn.execute('DELETE FROM books_ratings_link WHERE book=?',(id,))
@ -2540,7 +2540,7 @@ class LibraryDatabase2(LibraryDatabase, SchemaUpgrade, CustomColumns):
self.notify('metadata', [id]) self.notify('metadata', [id])
def set_author_sort(self, id, sort, notify=True, commit=True): def set_author_sort(self, id, sort, notify=True, commit=True):
if sort is None: if not sort:
sort = '' sort = ''
self.conn.execute('UPDATE books SET author_sort=? WHERE id=?', (sort, id)) self.conn.execute('UPDATE books SET author_sort=? WHERE id=?', (sort, id))
self.dirtied([id], commit=False) self.dirtied([id], commit=False)
@ -2613,7 +2613,7 @@ class LibraryDatabase2(LibraryDatabase, SchemaUpgrade, CustomColumns):
def set_identifiers(self, id_, identifiers, notify=True, commit=True): def set_identifiers(self, id_, identifiers, notify=True, commit=True):
cleaned = {} cleaned = {}
if identifiers is None: if not identifiers:
identifiers = {} identifiers = {}
for typ, val in identifiers.iteritems(): for typ, val in identifiers.iteritems():
typ, val = self._clean_identifier(typ, val) typ, val = self._clean_identifier(typ, val)