Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix the link_map containing invalid item_ids.

Browse Source 
I was able to reproduce the problem by renaming a series with a link to an existing series then running Manage Series. I can't guarantee that this fixes all cases, but it does fix this one.
This commit is contained in:
Charles Haley 2024-10-21 13:46:18 +01:00
parent da08e3798b
commit 7957587ea4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/calibre/db/tables.py
View File

@ -373,6 +373,7 @@ class ManyToOneTable(Table):
# We have to replace
new_id = existing_item
self.id_map.pop(item_id, None)
self.link_map.pop(item_id, None)
books = self.col_book_map.pop(item_id, set())
for book_id in books:
self.book_col_map[book_id] = existing_item
@ -522,6 +523,7 @@ class ManyToManyTable(ManyToOneTable):
# We have to replace
new_id = existing_item
self.id_map.pop(item_id, None)
self.link_map.pop(item_id, None)
books = self.col_book_map.pop(item_id, set())
# Replacing item_id with existing_item could cause the same id to
# appear twice in the book list. Handle that by removing existing
@ -615,7 +617,6 @@ class AuthorsTable(ManyToManyTable):
def rename_item(self, item_id, new_name, db):
ret = ManyToManyTable.rename_item(self, item_id, new_name, db)
if item_id not in self.id_map:
self.link_map.pop(item_id, None)
self.asort_map.pop(item_id, None)
else:
# Was a simple rename, update the author sort value