mirror of
https://github.com/kovidgoyal/calibre.git
synced 2025-07-09 03:04:10 -04:00
Faster bulk update for custom column is_multiple datatypes
This commit is contained in:
Kovid Goyal
parent
80a0725a0f
commit
7a68c4001b
@ -394,24 +394,12 @@ class BulkBase(Base):
|
||||
ans = list(ans)
|
||||
return ans
|
||||
|
||||
def process_each_book(self):
|
||||
return False
|
||||
|
||||
def initialize(self, book_ids):
|
||||
if not self.process_each_book():
|
||||
self.initial_val = val = self.get_initial_value(book_ids)
|
||||
val = self.normalize_db_val(val)
|
||||
self.setter(val)
|
||||
|
||||
def commit(self, book_ids, notify=False):
|
||||
if self.process_each_book():
|
||||
for book_id in book_ids:
|
||||
QCoreApplication.processEvents()
|
||||
val = self.db.get_custom(book_id, num=self.col_id, index_is_id=True)
|
||||
new_val = self.getter(val)
|
||||
if set(val) != new_val:
|
||||
self.db.set_custom(book_id, new_val, num=self.col_id, notify=notify)
|
||||
else:
|
||||
val = self.getter()
|
||||
val = self.normalize_ui_val(val)
|
||||
if val != self.initial_val:
|
||||
@ -474,9 +462,6 @@ class BulkSeries(BulkBase):
|
||||
self.db.set_custom(book_id, val, extra=s_index,
|
||||
num=self.col_id, notify=notify)
|
||||
|
||||
def process_each_book(self):
|
||||
return True
|
||||
|
||||
class RemoveTags(QWidget):
|
||||
|
||||
def __init__(self, parent, values):
|
||||
@ -539,8 +524,30 @@ class BulkText(BulkBase):
|
||||
if idx is not None:
|
||||
self.widgets[1].setCurrentIndex(idx)
|
||||
|
||||
def process_each_book(self):
|
||||
return self.col_metadata['is_multiple']
|
||||
def commit(self, book_ids, notify=False):
|
||||
if self.col_metadata['is_multiple']:
|
||||
remove = set()
|
||||
if self.removing_widget.checkbox.isChecked():
|
||||
for book_id in book_ids:
|
||||
remove |= set(self.db.get_custom(book_id, num=self.col_id,
|
||||
index_is_id=True))
|
||||
else:
|
||||
txt = unicode(self.removing_widget.tags_box.text())
|
||||
if txt:
|
||||
remove = set([v.strip() for v in txt.split(',')])
|
||||
txt = unicode(self.adding_widget.text())
|
||||
if txt:
|
||||
add = set([v.strip() for v in txt.split(',')])
|
||||
else:
|
||||
add = set()
|
||||
self.db.set_custom_bulk(book_ids, add=add, remove=remove, num=self.col_id)
|
||||
else:
|
||||
val = self.getter()
|
||||
val = self.normalize_ui_val(val)
|
||||
if val != self.initial_val:
|
||||
for book_id in book_ids:
|
||||
QCoreApplication.processEvents()
|
||||
self.db.set_custom(book_id, val, num=self.col_id, notify=notify)
|
||||
|
||||
def getter(self, original_value = None):
|
||||
if self.col_metadata['is_multiple']:
|
||||
|
||||
@ -313,6 +313,87 @@ class CustomColumns(object):
|
||||
self.conn.commit()
|
||||
return changed
|
||||
|
||||
def set_custom_bulk(self, ids, add=[], remove=[],
|
||||
label=None, num=None, notify=False):
|
||||
'''
|
||||
Fast algorithm for updating custom column is_multiple datatypes.
|
||||
Do not use with other custom column datatypes.
|
||||
'''
|
||||
if label is not None:
|
||||
data = self.custom_column_label_map[label]
|
||||
if num is not None:
|
||||
data = self.custom_column_num_map[num]
|
||||
if not data['editable']:
|
||||
raise ValueError('Column %r is not editable'%data['label'])
|
||||
if data['datatype'] != 'text' or not data['is_multiple']:
|
||||
raise ValueError('Column %r is not text/multiple'%data['label'])
|
||||
|
||||
add = self.cleanup_tags(add)
|
||||
remove = self.cleanup_tags(remove)
|
||||
remove = set(remove) - set(add)
|
||||
if not ids or (not add and not remove):
|
||||
return
|
||||
# get custom table names
|
||||
cust_table, link_table = self.custom_table_names(data['num'])
|
||||
|
||||
# Add tags that do not already exist into the custom cust_table
|
||||
all_tags = self.all_custom(num=data['num'])
|
||||
lt = [t.lower() for t in all_tags]
|
||||
new_tags = [t for t in add if t.lower() not in lt]
|
||||
if new_tags:
|
||||
self.conn.executemany('INSERT INTO %s(value) VALUES (?)'%cust_table,
|
||||
[(x,) for x in new_tags])
|
||||
|
||||
# Create the temporary temp_tables to store the ids for books and tags
|
||||
# to be operated on
|
||||
temp_tables = ('temp_bulk_tag_edit_books', 'temp_bulk_tag_edit_add',
|
||||
'temp_bulk_tag_edit_remove')
|
||||
drops = '\n'.join(['DROP TABLE IF EXISTS %s;'%t for t in temp_tables])
|
||||
creates = '\n'.join(['CREATE TEMP TABLE %s(id INTEGER PRIMARY KEY);'%t
|
||||
for t in temp_tables])
|
||||
self.conn.executescript(drops + creates)
|
||||
|
||||
# Populate the books temp cust_table
|
||||
self.conn.executemany(
|
||||
'INSERT INTO temp_bulk_tag_edit_books VALUES (?)',
|
||||
[(x,) for x in ids])
|
||||
|
||||
# Populate the add/remove tags temp temp_tables
|
||||
for table, tags in enumerate([add, remove]):
|
||||
if not tags:
|
||||
continue
|
||||
table = temp_tables[table+1]
|
||||
insert = ('INSERT INTO {tt}(id) SELECT {ct}.id FROM {ct} WHERE value=?'
|
||||
' COLLATE PYNOCASE LIMIT 1').format(tt=table, ct=cust_table)
|
||||
self.conn.executemany(insert, [(x,) for x in tags])
|
||||
|
||||
# now do the real work -- removing and adding the tags
|
||||
if remove:
|
||||
self.conn.execute(
|
||||
'''DELETE FROM %s WHERE
|
||||
book IN (SELECT id FROM %s) AND
|
||||
value IN (SELECT id FROM %s)'''
|
||||
% (link_table, temp_tables[0], temp_tables[2]))
|
||||
if add:
|
||||
self.conn.execute(
|
||||
'''
|
||||
INSERT INTO {0}(book, value) SELECT {1}.id, {2}.id FROM {1}, {2}
|
||||
'''.format(link_table, temp_tables[0], temp_tables[1])
|
||||
)
|
||||
# get rid of the temp tables
|
||||
self.conn.executescript(drops)
|
||||
self.conn.commit()
|
||||
|
||||
# set the in-memory copies of the tags
|
||||
for x in ids:
|
||||
tags = self.conn.get(
|
||||
'SELECT custom_%s FROM meta2 WHERE id=?'%data['num'],
|
||||
(x,), all=False)
|
||||
self.data.set(x, self.FIELD_MAP[data['num']], tags, row_is_id=True)
|
||||
|
||||
if notify:
|
||||
self.notify('metadata', ids)
|
||||
|
||||
def set_custom(self, id_, val, label=None, num=None,
|
||||
append=False, notify=True, extra=None):
|
||||
if label is not None:
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user