From 7ba42499b823cdb45eb53bc5b3328f264dd30c34 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 9 Jul 2014 08:36:00 +0530 Subject: [PATCH] Fix editing of cover priorities in metadata download preferences broken --- src/calibre/gui2/preferences/metadata_sources.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/calibre/gui2/preferences/metadata_sources.py b/src/calibre/gui2/preferences/metadata_sources.py index 9def448dae..52dc3a19e1 100644 --- a/src/calibre/gui2/preferences/metadata_sources.py +++ b/src/calibre/gui2/preferences/metadata_sources.py @@ -58,7 +58,7 @@ class SourcesModel(QAbstractTableModel): # {{{ return None col = index.column() - if role == Qt.DisplayRole: + if role in (Qt.DisplayRole, Qt.EditRole): if col == 0: return plugin.name elif col == 1: @@ -99,8 +99,11 @@ class SourcesModel(QAbstractTableModel): # {{{ self.enabled_overrides[plugin] = int(val) ret = True if col == 1 and role == Qt.EditRole: - self.cover_overrides[plugin] = int(val) - ret = True + try: + self.cover_overrides[plugin] = max(1, int(val)) + ret = True + except (ValueError, TypeError): + pass if ret: self.dataChanged.emit(index, index) return ret