From 7e8a5cf4490e2440d23168792a2c50e9e5c942aa Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 22 Dec 2021 10:40:32 +0530 Subject: [PATCH] Dont build NodeJS on windows It only builds with one version of Visual Studio. Typical web tech. --- bypy/sources.json | 4 ++-- bypy/windows.conf | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/bypy/sources.json b/bypy/sources.json index 494a6ebacb..8234f58864 100644 --- a/bypy/sources.json +++ b/bypy/sources.json @@ -446,8 +446,8 @@ { "name": "nodejs", - "comment": "Needed for Qt WebEngine", - "os": "macos,windows", + "comment": "Needed for building Qt WebEngine", + "os": "macos", "unix": { "filename": "nodejs-src.tar.gz", "hash": "sha256:394991ab9c259a68b0a72735d2fcee957a9c78138bf8d9e02cf8c04f6be5c673", diff --git a/bypy/windows.conf b/bypy/windows.conf index d961b0d030..3134411853 100644 --- a/bypy/windows.conf +++ b/bypy/windows.conf @@ -1,4 +1,4 @@ -# Requires installation of Visual Studio 2019 Community Edition, WiX Toolset, Git, Ruby, Python (2 and 3) and Perl +# Requires installation of Visual Studio 2019 Community Edition, WiX Toolset, Git, Ruby, NodeJS, Python (2 and 3) and Perl # git.exe must be in PATH. Must have ~120GB available disk space and 8GB RAM # Install certifi in python 3 with: # py.exe -m pip install certifi @@ -13,4 +13,5 @@ python 'py.exe' python2 'C:/Python27/python.exe' perl 'C:/Strawberry/perl/bin/perl.exe' ruby 'C:/Ruby30-x64/bin/ruby.exe' +nodejs 'C:/nodejs/node.exe' mesa 'C:/mesa'