From 83d03f9ae19ae40b12b298c861d18d2b2a48fecd Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sat, 24 Mar 2018 17:31:00 +0530 Subject: [PATCH] Delay load description strings to ensure they are translated --- src/pyj/book_list/cover_grid.pyj | 4 +++- src/pyj/book_list/custom_list.pyj | 4 +++- src/pyj/book_list/details_list.pyj | 4 +++- src/pyj/book_list/views.pyj | 12 ++++++------ 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/src/pyj/book_list/cover_grid.pyj b/src/pyj/book_list/cover_grid.pyj index 6924cea81f..2a29abe287 100644 --- a/src/pyj/book_list/cover_grid.pyj +++ b/src/pyj/book_list/cover_grid.pyj @@ -13,7 +13,9 @@ THUMBNAIL_MAX_HEIGHT = 4 * 100 THUMBNAIL_MIN_WIDTH = 3 * 35 THUMBNAIL_MIN_HEIGHT = 4 * 35 BORDER_RADIUS = 10 -DESCRIPTION = _('A grid of book covers') + +def description(): + return _('A grid of book covers') def cover_grid_css(): sel = '.' + COVER_GRID_CLASS diff --git a/src/pyj/book_list/custom_list.pyj b/src/pyj/book_list/custom_list.pyj index a909c6a015..f33f0954d3 100644 --- a/src/pyj/book_list/custom_list.pyj +++ b/src/pyj/book_list/custom_list.pyj @@ -15,7 +15,9 @@ from utils import fmt_sidx, safe_set_inner_html, sandboxed_html CUSTOM_LIST_CLASS = 'book-list-custom-list' ITEM_CLASS = CUSTOM_LIST_CLASS + '-item' -DESCRIPTION = _('A customizable list (see Preferences->Sharing over the net->Book list template)') + +def description(): + return _('A customizable list (see Preferences->Sharing over the net->Book list template)') def custom_list_css(): ans = '' diff --git a/src/pyj/book_list/details_list.pyj b/src/pyj/book_list/details_list.pyj index a9a1369ff4..df75fc4417 100644 --- a/src/pyj/book_list/details_list.pyj +++ b/src/pyj/book_list/details_list.pyj @@ -12,7 +12,9 @@ from utils import fmt_sidx, safe_set_inner_html, sandboxed_html DETAILS_LIST_CLASS = 'book-list-details-list' ITEM_CLASS = DETAILS_LIST_CLASS + '-item' -DESCRIPTION = _('A list with thumbnails and some book details') + +def description(): + return _('A list with thumbnails and some book details') THUMBNAIL_MAX_WIDTH = 35 * 3 THUMBNAIL_MAX_HEIGHT = 35 * 4 diff --git a/src/pyj/book_list/views.pyj b/src/pyj/book_list/views.pyj index 9f37cb7ec5..90136a4348 100644 --- a/src/pyj/book_list/views.pyj +++ b/src/pyj/book_list/views.pyj @@ -9,16 +9,16 @@ from gettext import gettext as _ from ajax import ajax_send from book_list.add import add_books_panel from book_list.cover_grid import ( - DESCRIPTION as COVER_GRID_DESCRIPTION, append_item as cover_grid_append_item, + description as COVER_GRID_DESCRIPTION, append_item as cover_grid_append_item, cover_grid_css, create_item as create_cover_grid_item, init as init_cover_grid ) from book_list.custom_list import ( - DESCRIPTION as CUSTOM_LIST_DESCRIPTION, append_item as custom_list_append_item, + description as CUSTOM_LIST_DESCRIPTION, append_item as custom_list_append_item, create_item as create_custom_list_item, custom_list_css, init as init_custom_list ) from book_list.details_list import ( - DESCRIPTION as DETAILS_LIST_DESCRIPTION, append_item as details_list_append_item, + description as DETAILS_LIST_DESCRIPTION, append_item as details_list_append_item, create_item as create_details_list_item, details_list_css, init as init_details_list ) @@ -420,9 +420,9 @@ def create_mode_panel(container_id): back() )) - ci(_('Cover grid'), COVER_GRID_DESCRIPTION, 'cover_grid') - ci(_('Detailed list'), DETAILS_LIST_DESCRIPTION, 'details_list') - ci(_('Custom list'), CUSTOM_LIST_DESCRIPTION, 'custom_list') + ci(_('Cover grid'), COVER_GRID_DESCRIPTION(), 'cover_grid') + ci(_('Detailed list'), DETAILS_LIST_DESCRIPTION(), 'details_list') + ci(_('Custom list'), CUSTOM_LIST_DESCRIPTION(), 'custom_list') container.appendChild(E.div()) create_item_list(container.lastChild, items, _('Choose a display mode for the list of books from below'))