Cutlery/calibre
1
0
Fork 0
mirror of https://github.com/kovidgoyal/calibre.git synced 2025-07-09 03:04:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix a regression in the previous release that broke using Tab key to move around the book list while editing cells

Browse Source 
Workaround for regression introduced in Qt 6.7.2
This commit is contained in:
Kovid Goyal 2024-09-05 13:59:44 +05:30
parent 041e12ddee
commit 85aba43903
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/calibre/gui2/library/views.py
View File

@ -11,6 +11,7 @@ from collections import OrderedDict
from functools import partial
from qt.core import (
QAbstractItemDelegate,
QAbstractItemView,
QDialog,
QDialogButtonBox,
@ -1636,6 +1637,29 @@ class BooksView(QTableView): # {{{
def close(self):
self._model.close()
def closeEditor(self, editor, hint):
# As of Qt 6.7.2, for some reason, Qt opens the next editor after
# closing this editor and then immediately closes it again. So
# workaround the bug by opening the editor again after an event loop
# tick.
orig = self.currentIndex()
move_by = None
if hint is QAbstractItemDelegate.EndEditHint.EditNextItem:
move_by = QAbstractItemView.CursorAction.MoveNext
elif hint is QAbstractItemDelegate.EndEditHint.EditPreviousItem:
move_by = QAbstractItemView.CursorAction.MovePrevious
if move_by is not None:
hint = QAbstractItemDelegate.EndEditHint.NoHint
ans = super().closeEditor(editor, hint)
if move_by is not None and self.currentIndex() == orig:
index = self.moveCursor(move_by,Qt.KeyboardModifier.NoModifier)
if index.isValid():
def edit():
self.setCurrentIndex(index)
self.edit(index)
QTimer.singleShot(0, edit)
return ans
def set_editable(self, editable, supports_backloading):
self._model.set_editable(editable)