From 89f5a0b183b5ee2472c022e8b3bc5302d11055a8 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 4 Sep 2019 07:52:45 +0530 Subject: [PATCH] Do not run the webengine build test on windows as it causes a crash on exit under cygwin+ssh --- src/calibre/test_build.py | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/calibre/test_build.py b/src/calibre/test_build.py index ec8ebce75e..db92a9b920 100644 --- a/src/calibre/test_build.py +++ b/src/calibre/test_build.py @@ -223,26 +223,28 @@ class BuildTest(unittest.TestCase): if iswindows: from PyQt5.Qt import QtWin QtWin - p = QWebEnginePage() + if has_headless: + # Causes crash on exit under windows+cygwin+ssh + p = QWebEnginePage() - def callback(result): - callback.result = result - if hasattr(print_callback, 'result'): - Application.instance().quit() + def callback(result): + callback.result = result + if hasattr(print_callback, 'result'): + Application.instance().quit() - def print_callback(result): - print_callback.result = result - if hasattr(callback, 'result'): - Application.instance().quit() + def print_callback(result): + print_callback.result = result + if hasattr(callback, 'result'): + Application.instance().quit() - p.runJavaScript('1 + 1', callback) - p.printToPdf(print_callback) - QTimer.singleShot(5000, lambda: Application.instance().quit()) - app.exec_() - self.assertEqual(callback.result, 2) - self.assertIn(b'Skia/PDF', bytes(print_callback.result)) + p.runJavaScript('1 + 1', callback) + p.printToPdf(print_callback) + QTimer.singleShot(5000, lambda: Application.instance().quit()) + app.exec_() + self.assertEqual(callback.result, 2) + self.assertIn(b'Skia/PDF', bytes(print_callback.result)) + del p del na - del p del app del QWebEnginePage