python3: add Cookie wrapper to polyglot

src/calibre/srv/tests/auth.py

@@ -6,7 +6,7 @@ from __future__ import (unicode_literals, division, absolute_import,
 __license__ = 'GPL v3'
 __copyright__ = '2015, Kovid Goyal <kovid at kovidgoyal.net>'
 
-import base64, subprocess, os, cookielib, time
+import base64, subprocess, os, time
 from collections import namedtuple
 try:
     from distutils.spawn import find_executable
@@ -19,6 +19,7 @@ from calibre.srv.tests.base import BaseTest, TestServer
 from calibre.srv.routes import endpoint, Router
 from polyglot.builtins import iteritems, itervalues
 from polyglot import http_client
+from polyglot.http_cookie import CookieJar
 from polyglot.urllib import (build_opener, HTTPBasicAuthHandler,
         HTTPCookieProcessor, HTTPDigestAuthHandler, HTTPError)
 
@@ -283,7 +284,7 @@ class TestAuth(BaseTest):
             auth_handler = HTTPDigestAuthHandler()
             url = 'http://localhost:%d%s' % (server.address[1], '/android')
             auth_handler.add_password(realm=REALM, uri=url, user='testuser', passwd='testpw')
-            cj = cookielib.CookieJar()
+            cj = CookieJar()
             cookie_handler = HTTPCookieProcessor(cj)
             r = build_opener(auth_handler, cookie_handler).open(url)
             self.ae(r.getcode(), http_client.OK)

src/calibre/srv/utils.py

@@ -7,7 +7,6 @@ __license__ = 'GPL v3'
 __copyright__ = '2015, Kovid Goyal <kovid at kovidgoyal.net>'
 
 import errno, socket, select, os, time
-from Cookie import SimpleCookie
 from contextlib import closing
 from email.utils import formatdate
 from operator import itemgetter
@@ -23,6 +22,7 @@ from calibre.utils.logging import ThreadSafeLog
 from calibre.utils.shared_file import share_open, raise_winerror
 from polyglot.builtins import iteritems, map, unicode_type, range
 from polyglot import reprlib
+from polyglot.http_cookie import SimpleCookie
 from polyglot.urllib import parse_qs, quote as urlquote
 
 HTTP1  = 'HTTP/1.0'

src/calibre/utils/browser.py

@@ -6,11 +6,11 @@ __copyright__ = '2010, Kovid Goyal <kovid@kovidgoyal.net>'
 __docformat__ = 'restructuredtext en'
 
 import copy, ssl
-from cookielib import CookieJar, Cookie
 
 from mechanize import Browser as B, HTTPSHandler
 
 from polyglot import http_client
+from polyglot.http_cookie import CookieJar, Cookie
 
 
 class ModernHTTPSHandler(HTTPSHandler):

src/polyglot/http_cookie.py

@@ -0,0 +1,12 @@
+#!/usr/bin/env python2
+# vim:fileencoding=utf-8
+# License: GPL v3 Copyright: 2019, Eli Schwartz <eschwartz@archlinux.org>
+
+from polyglot.builtins import is_py3
+
+if is_py3:
+    from http.cookies import SimpleCookie    # noqa
+    from http.cookiejar import CookieJar, Cookie  # noqa
+else:
+    from Cookie import SimpleCookie  # noqa
+    from cookielib import CookieJar, Cookie  # noqa